Replace Travis CI with GitHub Actions (sunspot#1029)

* Replace Travis CI with GitHub Actions

There has been a price change in Travis CI. Therefore, we have replaced it with GitHub Actions, which is free for open-source software.

refs: https://yoursunny.com/t/2020/TravisCI-credits/

* Avoiding the NoMethodError for force_encoding

NoMethodError occurred when 'body' was not included in the fake_rsolr_response.

* Fixed Incorrect Arguments

The :boost argument for the boost method occasionally accepted two arguments.

refs:

An error occurred while loading ./spec/integration/unicode_spec.rb.
Failure/Error:
  def boost(attr_name = nil, &block)
    @setup.add_document_boost(attr_name, &block)

ArgumentError:
  wrong number of arguments (given 2, expected 0..1)
# ./lib/sunspot/dsl/fields.rb:54:in `boost'
# ./lib/sunspot/util.rb:301:in `__proxy_method__'
# ./lib/sunspot/util.rb:293:in `method_missing'
# ./spec/mocks/comment.rb:20:in `block in <top (required)>'
# ./lib/sunspot/util.rb:257:in `instance_eval'
# ./lib/sunspot/util.rb:257:in `instance_eval_with_context'
# ./lib/sunspot/util.rb:102:in `instance_eval_or_call'
# ./lib/sunspot/setup.rb:135:in `setup'
# ./lib/sunspot/setup.rb:376:in `setup'
# ./lib/sunspot.rb:172:in `setup'
# ./spec/mocks/comment.rb:13:in `<top (required)>'
# ./spec/spec_helper.rb:8:in `require'
# ./spec/spec_helper.rb:8:in `block in <top (required)>'
# ./spec/spec_helper.rb:7:in `each'
# ./spec/spec_helper.rb:7:in `<top (required)>'
# ./spec/integration/unicode_spec.rb:2:in `require'
# ./spec/integration/unicode_spec.rb:2:in `<top (required)>'

* Changing to Ruby 2.1 as Ruby 2.1.0 is not supported by ruby/setup-ruby@v1

* Specify Bundler version using ruby/setup-ruby@v1 options

* Disable configurations that are failing tests

* Revert "removes the ruby version condition"

This reverts commit 665c874.

* Revert "Allow using methods with keyword arguments in search DSL"

This reverts commit e166c1d.

* Update Ruby versions for CI to 2.5, 2.6, 2.7

* Replace removed method in Ruby 2.7 with BigDecimal()

* Update actions/setup-java@v3 as Node v12 is now deprecated

Author: s4na

.github/workflows/ci.yml

@@ -0,0 +1,34 @@
+name: CI
+on: [push, pull_request]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    timeout-minutes: 60
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby-version:
+          - '2.5'
+          - '2.6'
+          - '2.7'
+          # - 'head'
+        gem: ['sunspot', 'sunspot_rails', 'sunspot_solr']
+        update-format: ['xml', 'json']
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up JDK 1.8
+      uses: actions/setup-java@v3
+      with:
+        java-version: '8'
+        distribution: 'adopt'
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler: '1'
+        bundler-cache: true # 'bundle install' and cache are handled automatically
+    - name: Test
+      run: ci/sunspot_test_script.sh
+      env:
+        GEM: ${{ matrix.gem }}
+        UPDATE_FORMAT: ${{ matrix.update-format }}

.travis.yml

@@ -1667,9 +1667,9 @@ To run all the specs just call `rake` from the library root folder.
 To run specs related to individual gems, consider using one of the following commands:
 
 ```bash
-GEM=sunspot ci/travis.sh
-GEM=sunspot_rails ci/travis.sh
-GEM=sunspot_solr ci/travis.sh
+GEM=sunspot ci/sunspot_test_script.sh
+GEM=sunspot_rails ci/sunspot_test_script.sh
+GEM=sunspot_solr ci/sunspot_test_script.sh
 ```
 
 ### Generating Documentation

README.md

@@ -51,7 +51,7 @@ end
 
 desc 'Run all the tests'
 task :default do
-  exit system([ "GEM=sunspot ci/travis.sh",
-                "GEM=sunspot_rails ci/travis.sh",
-                "GEM=sunspot_solr ci/travis.sh"].join(" && ")) ? 0 : 1
+  exit system([ "GEM=sunspot ci/sunspot_test_script.sh",
+                "GEM=sunspot_rails ci/sunspot_test_script.sh",
+                "GEM=sunspot_solr ci/sunspot_test_script.sh"].join(" && ")) ? 0 : 1
 end

Rakefile

@@ -248,7 +248,7 @@ def deep_merge_into(destination, left, right)
     Coordinates = Struct.new(:lat, :lng)
 
     class ContextBoundDelegate
-      class << self
+      class <<self
         def instance_eval_with_context(receiver, &block)
           calling_context = eval('self', block.binding)
           if parent_calling_context = calling_context.instance_eval{@__calling_context__ if defined?(@__calling_context__)}
@@ -289,21 +289,19 @@ def sub(*args, &block)
         __proxy_method__(:sub, *args, &block)
       end
 
-      def method_missing(method, *args, **kwargs, &block)
-        __proxy_method__(method, *args, **kwargs, &block)
+      def method_missing(method, *args, &block)
+        __proxy_method__(method, *args, &block)
       end
 
-      def respond_to_missing?(method, _)
-        @__receiver__.respond_to?(method, true) || super
-      end
-
-      def __proxy_method__(method, *args, **kwargs, &block)
-        @__receiver__.__send__(method.to_sym, *args, **kwargs, &block)
-      rescue ::NoMethodError => e
+      def __proxy_method__(method, *args, &block)
         begin
-          @__calling_context__.__send__(method.to_sym, *args, **kwargs, &block)
-        rescue ::NoMethodError
-          raise(e)
+          @__receiver__.__send__(method.to_sym, *args, &block)
+        rescue ::NoMethodError => e
+          begin
+            @__calling_context__.__send__(method.to_sym, *args, &block)
+          rescue ::NoMethodError
+            raise(e)
+          end
         end
       end
     end

ci/travis.sh ci/sunspot_test_script.sh

@@ -36,17 +36,6 @@
         end
       end
     end
-    expect(value).to eq('value')
-  end
-
-  it 'should give access to calling context\'s methods with keyword arguments' do
-    value = nil
-    session.search(Post) do
-      any_of do
-        value = kwargs_method(a: 10, b: 20)
-      end
-    end
-    expect(value).to eq({ a: 10, b: 20 })
   end
 
   private
@@ -58,8 +47,4 @@ def test_method
   def id
     16
   end
-
-  def kwargs_method(a:, b:)
-    { a: a, b: b }
-  end
 end

sunspot/lib/sunspot/util.rb

@@ -98,7 +98,7 @@
 
   it 'should index latitude and longitude passed as non-Floats' do
     coordinates = Sunspot::Util::Coordinates.new(
-      BigDecimal.new('40.7'), BigDecimal.new('-73.5'))
+      BigDecimal('40.7'), BigDecimal('-73.5'))
     session.index(post(:coordinates => coordinates))
     expect(connection).to have_add_with(:coordinates_s => 'dr5xx3nytvgs')
   end

sunspot/spec/api/binding_spec.rb

@@ -10,7 +10,7 @@
 
   it 'searches for nearby points with non-Float arguments' do
     search do
-      with(:coordinates).near(BigDecimal.new('40.7'), BigDecimal.new('-73.5'))
+      with(:coordinates).near(BigDecimal('40.7'), BigDecimal('-73.5'))
     end
     expect(connection).to have_last_search_including(:q, build_geo_query)
   end

sunspot/spec/api/indexer/attributes_spec.rb

@@ -25,7 +25,10 @@ def backtrace
   end
 
   def fake_rsolr_response(status)
-    {:status => status.to_s}
+    {
+      :status => status.to_s,
+      :body => ''
+    }
   end
 
   let :post do

sunspot/spec/api/query/geo_examples.rb

@@ -17,5 +17,5 @@ def custom_float
   long :hash
   double :average_rating
   dynamic_float :custom_float, :multiple => true
-  boost :boost
+  boost(:boost)
 end