Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function readPOPCpp() doesn't work with tab-separated input ped file #15

Open
filippob opened this issue May 25, 2020 · 3 comments
Open

Comments

@filippob
Copy link
Collaborator

filippob commented May 25, 2020

This problem is a tab-separated issue similar to #10.
The function readPOPCpp() reads the genotype file (Plnk ped file) to extract information on sample IDs and the group/population these belong to.
This is a non-exported function is used within the function snpInsideRunsCpp() to prepare data for plots (plot_SnpsInRuns and plot_manhattanRuns): it works with space-separated ped files, but not with tab-separated ped files, and in this latter case the proportion of SNPs in runs is not computed correctly and goes to Infinity.
Perhaps this can be fixed for next release of the package?

@bunop
Copy link
Contributor

bunop commented May 25, 2020

The same applies for genotype <- (strsplit(oneLine, " ")) in slidingRUNS.run and for genotype <- (strsplit(oneLine, " ")) in consecutiveRUNS.run: the supported format for .map and .ped is space separated values. Did we declare this somewhere in documentation?

@filippob
Copy link
Collaborator Author

We did not specify this in the documentation: therefore we either modify these functions to accept also tab-separated ped files, or make this clear in the manual and vignette.

@bunop
Copy link
Contributor

bunop commented May 25, 2020

So the problem is deal with tab separated files, we already discussed this in #10 please refer to #10 for any TAB related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants