Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 useArrowFunction breaks working code on safe lint #4967

Open
1 task done
RSharmaBB opened this issue Jan 24, 2025 · 1 comment · May be fixed by #5170
Open
1 task done

💅 useArrowFunction breaks working code on safe lint #4967

RSharmaBB opened this issue Jan 24, 2025 · 1 comment · May be fixed by #5170
Assignees
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@RSharmaBB
Copy link

Environment information

Repo to reproduce: https://github.com/RSharmaBB/biome-arrow-reproduce

It looks like the `useArrowFunction` rule is not adding parenthesis when needed resulting in breaking changes when running `biome check --write`. 

This is expected to be a safe action according to the docs
https://biomejs.dev/guides/getting-started/

Rule name

useArrowFunction

Playground link

https://github.com/RSharmaBB/biome-arrow-reproduce

Expected result

It should have wrapped the returned object in parenthesis.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@RSharmaBB RSharmaBB added the S-Needs triage Status: this issue needs to be triaged label Jan 24, 2025
@dyc3 dyc3 added S-Bug-confirmed Status: report has been confirmed as a valid bug A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jan 24, 2025
@github-actions github-actions bot removed the S-Needs triage Status: this issue needs to be triaged label Jan 24, 2025
@siketyan siketyan self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants