🐛 Biome suggests "Suppress rule …" above an actual fix

[lgarron]

VS Code version

1.96.4

Extension version

2.3.0

Biome version

1.9.3

Operating system

• Windows
• macOS
• Linux

Description

1. Run:

mkdir /tmp/biome-suggestion-order && cd /tmp/biome-suggestion-order
npm install --save-dev @biomejs/biome
npx @biomejs/biome init
echo "console.log(!!!false);" > index.ts
echo 'console.log("The number is" + 5);' >> index.ts
code /tmp/biome-suggestion-order

2. Open index.ts and place the cursor over either error.
3. Invoke "Quick Fix…" using the keyboard shortcut (⌥.).
4. Press the same keyboard shortcut again to accept the first suggestion.

This results in a biome-ignore comment being added instead of the actual suggested fix.

This is because the "Suppress rule …" option usually shows before the actual fix suggestion:

Steps to reproduce

See above.

Expected behavior

I would find it much more useful if the default suggestion was the actual fix. Due to other UX choices by VS Code, this would be significantly more convenient than if it is the second suggestion (see below).

Does this issue occur when using the CLI directly?

Not sure / Not applicable

Link to a minimal reproduction

See above

Logs

[lgarron]

Note that this interacts with #5057

If both are addressed, it would be very easy to review and accept a lot of suggestions quickly (which is often useful when adding/upgrading Biome for a project). I have "Go to Next Problem" bound to ⌘8, so for me this would be:

• ⌘8 ⌘. ⌘.
• Repeat for each issue.

This allows keeping one key constantly pressed (⌘) and alternating between only two other keys. Super simple to learn and use!

If the occasional default suggestion is not correct, I can pause between two consecutive ⌘. invocations. And even if I make a mistake, it's easy to go back.

Contrast this to a double workaround, which requires letting go and pressing ⌘ twice for each error and using four additional keys:

• ⌘8 → ⌘. ↓ ⌘.
• Repeat for each issue.

I know it sounds a bit picky, but the inputs are precise and I find this kind of keyboard dance very distracting when I'm trying to focus on reviewing linter issues in bulk. It would be really nice the other way!

[nhedger]

The extension has no control over the order of these items, they are supplied by the LSP server.

I'll see if this can be addressed in the main repo.