Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Support overriding configuration per workspace on LSP #5089

Open
3 tasks
siketyan opened this issue Feb 11, 2025 · 4 comments
Open
3 tasks

📎 Support overriding configuration per workspace on LSP #5089

siketyan opened this issue Feb 11, 2025 · 4 comments

Comments

@siketyan
Copy link
Member

siketyan commented Feb 11, 2025

Description

Continues #5084

Biome LSP server already supports configuration per workspace, but the config file is automatically found from the current directory and cannot be overriden. It also have --config-path CLI flag, but it overrides the configuration on every workspace.

This task is to support overriding the configuration for each workspace on LSP. I am ready to work on this and this issue is only for tracking.

TODOs:

@nhedger
Copy link
Member

nhedger commented Feb 11, 2025

FYI, --config-path is currently being used by the v3 prerelease extension for VS Code

@ematipico
Copy link
Member

I believe --config-path still makes sense (for now). It has different semantics.

Let's keep it for now and see if it makes sense to keep it or not.

@siketyan siketyan changed the title 📎 Support overriding configuration per workspace 📎 Support overriding configuration per workspace on LSP Feb 12, 2025
@siketyan
Copy link
Member Author

@nhedger @ematipico
Thank you for letting me know about that. I'll keep --config-path for now.

@nhedger
Copy link
Member

nhedger commented Feb 18, 2025

@siketyan FYI, we've finally decided to remove --config-path from the pre-release extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants