Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_css_analyzer): update known pseudo elements #5118

Merged
merged 9 commits into from
Feb 21, 2025

Conversation

Th3S4mur41
Copy link
Contributor

Summary

Add ::slotted to the list of known pseudo elements

closes #5116

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-CSS Language: CSS labels Feb 13, 2025
@Th3S4mur41 Th3S4mur41 requested a review from dyc3 February 13, 2025 20:04
@Th3S4mur41
Copy link
Contributor Author

@dyc3 @ematipico thinking about it, I'd say the current fix is wrong...

:slotted is always a level one pseudo element, not level two.
In that regard, it is rather like :highlight which also requires parenthesis.

So, wouldn't it make more sense to place it under OTHER_PSEUDO_ELEMENTS ?

Also some pointer to help me where to look to fix the tests would be highly appreciated 😉

Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #5118 will not alter performance

Comparing Th3S4mur41:fix/issue-5116 (d8f0cad) with main (d739883)

Summary

✅ 94 untouched benchmarks

@ematipico
Copy link
Member

ematipico commented Feb 20, 2025

@Th3S4mur41

You can suggest a different fix, like creating a new list, however I still don't understand why that's needed. Or, more like, I don't understand why the fix is wrong.

As for fixing the test, you need to update the snapshot tests. The contributing document explains that

@ematipico ematipico merged commit afe2131 into biomejs:main Feb 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 Unexpected unknown pseudo-elements: slotted
3 participants