Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not parse XMLs manually #4

Open
kinow opened this issue Sep 26, 2015 · 1 comment
Open

Do not parse XMLs manually #4

kinow opened this issue Sep 26, 2015 · 1 comment

Comments

@kinow
Copy link
Member

kinow commented Sep 26, 2015

At the moment we have a bunch of if conditions for parsing the XMLs, and we also use regular expressions.

Yesterday I committed a fix for a NPE that happened because of one of these if's. This is still possible to happen, and makes our code less readable and brittle.
kinow added a commit that referenced this issue Sep 26, 2015
@kinow
Issue #4 use XStream for parsing XMLs output of qstat -fx
b915cd0
@kinow kinow closed this as completed Sep 26, 2015
@kinow kinow reopened this Sep 26, 2015
@kinow
Copy link
Member Author

kinow commented Sep 26, 2015

We have to fix that in other classes as well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kinow