Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Let Disco also generate the phpstorm Meta file for type lookups #19

Open
shochdoerfer opened this issue Dec 7, 2015 · 6 comments

Comments

@shochdoerfer
Copy link
Member

PhpStorm supports a so-called Meta file helping with autocompletion for container calls. Add a (Phing) task to generate such a file for the given container configuration to enable autocomplete support for the return values of the BeanFactory::get() calls.

@SenseException
Copy link
Contributor

What about using Composer to create the PHPStorm meta-file on Update/Install?
Also: If a meta-file already exists in a project using Disco, it shouldn't be overridden.

@shochdoerfer
Copy link
Member Author

shochdoerfer commented Sep 12, 2016

@SenseException My current plan is rather to generate the files when the cache files are written because you want to have a meta file matching the current configuration.

But open to suggestions / improvements ;)

@SenseException
Copy link
Contributor

@shochdoerfer The goal is to manually start the phing task after the dev made changes?

@shochdoerfer
Copy link
Member Author

@SenseException That is what I had in mind then I added the issue. Downside is you would need to manually build the meta-file which means potentially it could be out-of-sync with the configuration. That is why I thought Disco should spit out the file additionally to the cached configuration. That way both files would always be in sync.

@SenseException
Copy link
Contributor

I wouldn't make this file and its generating code a part of this repository. It is PHPStorm only and no help for other IDEs. It is also not needed for running Disco. If this is about PHPStorm, I suggest to create a PHPStorm plugin to separate a development helper from the library.

@shochdoerfer
Copy link
Member Author

My idea was to add a configuration setting so that the user could toggle the generation of the file.

@shochdoerfer shochdoerfer modified the milestone: 0.7.0 Nov 7, 2016
@shochdoerfer shochdoerfer changed the title Add (Phing) task to generate the phpstorm Meta file Let Disco also generate the phpstorm Meta file for type lookups Nov 27, 2016
@shochdoerfer shochdoerfer changed the title Let Disco also generate the phpstorm Meta file for type lookups [Feature] Let Disco also generate the phpstorm Meta file for type lookups Dec 4, 2016
@shochdoerfer shochdoerfer modified the milestone: 0.7.0 Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants