Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Sylius attributes for strategy configuration #8

Open
shochdoerfer opened this issue Jun 23, 2024 · 1 comment
Open

Move to Sylius attributes for strategy configuration #8

shochdoerfer opened this issue Jun 23, 2024 · 1 comment
Assignees
Milestone

Comments

@shochdoerfer
Copy link
Member

Currently, the URL resolving strategies are hardcoded in various parts of the plugin. Switch to an attribute-style of configuration to allow others to easily extend and add custom strategies.

@shochdoerfer shochdoerfer self-assigned this Jun 23, 2024
@shochdoerfer
Copy link
Member Author

The best(?) approach might be to remove the Strategy creation logic from the Whitelist entity and replace it with a custom Doctrine type:

This approach seems ideal as it would not cause a BC break as far as I can tell right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant