instance: input vout index vs tx vin index mess-up (again)

Author: kallewoof

instance.cpp

@@ -188,7 +188,7 @@ bool Instance::setup_environment(unsigned int flags) {
     if (tx) {
         if (txin && txin_index > -1) {
             std::vector<CTxOut> spent_outputs;
-            spent_outputs.emplace_back(txin->vout[txin_index]);
+            spent_outputs.emplace_back(txin->vout[txin_vout_index]);
             if (tx->vin.size() == 1) {
                 txdata.Init(*tx.get(), std::move(spent_outputs), has_preamble);
             }

instance.h

@@ -22,6 +22,12 @@ class Instance {
     ECCVerifyHandle evh;
     CTransactionRef tx;
     CTransactionRef txin;
+    /*
+     * INPUT TX VOUT            TX VIN
+     * [0]                      [0]*    <-- txin_index==0
+     * [1]*                     [1]
+     *    `-- txin_vout_index==1
+     */
     int64_t txin_index;             ///< index of the input txid in tx's inputs
     int64_t txin_vout_index;        ///< index inside txin of the output to tx
     std::vector<CAmount> amounts;