Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Modifier key for hot pressing a button #3271

Open
2 tasks done
dnmeid opened this issue Feb 8, 2025 · 3 comments
Open
2 tasks done

Change: Modifier key for hot pressing a button #3271

dnmeid opened this issue Feb 8, 2025 · 3 comments
Labels
area/gui GUI / Webapp related Enhancement New feature or request

Comments

@dnmeid
Copy link
Member

dnmeid commented Feb 8, 2025

Is this a feature relevant to companion itself, and not a module?

  • I believe this to be a feature for companion, not a module

Is there an existing issue for this?

  • I have searched the existing issues

Describe the feature

Now with next update beeing a major number, I feel we can be a little more daring with some changes.
So I' like to propose to change the modifier key for the hot pressing a button in the grid from shift to control.
Reason: aligning with common and standard key-combinations in other popular software.
We want to introduce better edition features for the grid and lists like moving and selecting multiple controls. There are some widely used workflows: klick and drag to span a selection boundary, alt-klick to toggle an item's selection, shift-klick to select range until this item, control-klick for application dependent actions. Especially in (action-) lists that often need scrolling the range selection is a common task.
If we stay on shift-klick for hot pressing, we would need to use a different modifier for range selection and that would be way off established standards.

Usecases

No response

@dnmeid dnmeid added area/gui GUI / Webapp related Enhancement New feature or request labels Feb 8, 2025
@Julusian
Copy link
Member

Julusian commented Feb 8, 2025

I'm open to changing this, but I'm not sure about it being control.
In my experience it is usually control that will toggle an items selection. And I worry that using control will cause accidental presses when using ctrl-x and ctrl-v to move things around

I am wondering if we should go more radical; in some ways it is a little odd that we blur the lines between this grid being an editor with the hotkey to trigger presses. But I don't have any ideas on what to do instead, it is useful..

@dnmeid
Copy link
Member Author

dnmeid commented Feb 8, 2025

In terms of selection I most often see alt-click for toggling. E.g. it is used in the Windows explorer, in macOS finder, in nearly all Linux window managers, in the complete Microsoft office suite, in Libre office, Open office, in all the Adobe applications. Do you have an example where control is used for toggling selection?
I'd say for the hot press, control is the most logical choice because you actually execute something with it and that is exactly what control is meant for.
In text processors usually shift-arrow extends the selection (=range selection) and control-arrow moves the cursor by a word (= non selection operation).

@dnmeid
Copy link
Member Author

dnmeid commented Feb 11, 2025

I just realised Libre office calc does indeed use control for toggle selection of cells.
To be clear, for me the goal is not to have the shortcut replaced exactly by control. The goal is to align our shourtcuts with what is used the most in similar popular applications.
There doesn't seem to be the one and only standard, so maybe we'll just have to collect some examples and then decide which applications seem to be the best practice to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gui GUI / Webapp related Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants