Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics serviceName can exceed 63 naming limit #1590

Open
guntiskarulis opened this issue Aug 30, 2024 · 0 comments
Open

Metrics serviceName can exceed 63 naming limit #1590

guntiskarulis opened this issue Aug 30, 2024 · 0 comments
Labels
triage Issues/PRs that need to be reviewed

Comments

@guntiskarulis
Copy link

guntiskarulis commented Aug 30, 2024

Which component:
Controller: 0.24.5
Helm chart: 2.14.1

Describe the bug
Metrics service name can exceed 63 character limit, because Helm template engine will include sealed-secrets.fullname to generate name and in this helper function it will truncates string to 63 characters, hoverver service name itself will add additional characters to the service name, i.e -metrics thus deployments will fail.

Using nameOverride and fullNameOverride will update selector labels, thus breaking controller deployment.

To Reproduce
Deploy sealed-secrets chart, with Release.Name close to 63 characters.

Expected behavior
Provide a way using Helm values to override metrics service name.

Version of Kubernetes:

  • Output of kubectl version:
Client Version: v1.30.3
Server Version: v1.30.3
@guntiskarulis guntiskarulis added the triage Issues/PRs that need to be reviewed label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issues/PRs that need to be reviewed
Projects
None yet
Development

No branches or pull requests

1 participant