Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up non-idiomatic code in vignette #14

Open
seandavi opened this issue Oct 21, 2023 · 0 comments
Open

Clean up non-idiomatic code in vignette #14

seandavi opened this issue Oct 21, 2023 · 0 comments

Comments

@seandavi
Copy link
Collaborator

from @antagomir

While I went through the vignette, I noticed some minor points that you may find useful for your next version. Use as you wish:

  1. colData(cpd)$country (and other similar cases) can be also written more shortly just like: cpd$country
  2. ggplot(as.data.frame(colData(cpd)))... -> the as.data.frame() was necessary until very recently, but not needed any more since the issue was solved ; the latest ggplot2 version allows this:
    ggplot(colData(cpd))... 
    
    We are adding a reference to this data resource in the OMA Gitbook (beta version, under active development)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant