Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support chart repositories behind SSL certificate authentication #3

Open
JeanMertz opened this issue May 13, 2017 · 1 comment
Open

Comments

@JeanMertz
Copy link
Contributor

JeanMertz commented May 13, 2017

Our current API looks like this:

apiVersion: v1
charts:
- opsgoodness/prometheus-operator:
    repo: http://charts.opsgoodness.com

We should also support SSL-based authentication, potentially with an API like this:

apiVersion: v1
charts:
- opsgoodness/prometheus-operator:
    repo:
      url: https://charts.opsgoodness.com
      caFile: /path/to/ca
      certFile: /path/to/cert
      keyFile: /path/to/key

However, given that we support templating within charts.yml, we could also consider to not point to files, but instead embed the data as base64-encoded strings, as this makes it easier to inject the values in an automated/CI-environment using environment variables:

apiVersion: v1
charts:
- opsgoodness/prometheus-operator:
    repo:
      url: https://charts.opsgoodness.com
      ca: {{ env "MY_CA_CONTENT" | b64enc }}
      cert: {{ env "MY_CERT_CONTENT" | b64enc }}
      key: {{ env "MY_KEY_CONTENT" | b64enc }}

Or support both formats, if that makes sense.

@JeanMertz
Copy link
Contributor Author

JeanMertz commented May 13, 2017

Ideally, we'd also rename repo to repository, as the reduction in characters does not offset the loss in explicitness.

I just remembered Helm also uses helm repo list|add|remove, so it might make more sense to keep the current name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant