Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the correct SHA for pr-release.yml #4348

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix: use the correct SHA for pr-release.yml #4348

merged 1 commit into from
Jun 13, 2024

Conversation

avivkeller
Copy link
Contributor

This PR fixes the pr-release.yml workflow to use the correct SHA, rather than trying to get a non-existant ${{ github.event.pull_request.head.ref }}.

This PR has the workflow get the SHA associated with the issue, verify it is the correct SHA, and then use it.

@avivkeller avivkeller requested a review from flybayer as a code owner June 11, 2024 20:07
Copy link

changeset-bot bot commented Jun 11, 2024

⚠️ No Changeset found

Latest commit: 4e7007b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@siddhsuresh siddhsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! LGTM

@siddhsuresh siddhsuresh merged commit 2f3c552 into blitz-js:main Jun 13, 2024
28 of 29 checks passed
@blitzjs-bot
Copy link
Contributor

Added @redyetidev contributions for code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants