Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textual 2.0.0 support #713

Open
1 task done
gepbird opened this issue Feb 16, 2025 · 1 comment
Open
1 task done

textual 2.0.0 support #713

gepbird opened this issue Feb 16, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@gepbird
Copy link

gepbird commented Feb 16, 2025

Is there an existing proposal for this?

  • I have searched the existing proposals

Is your feature request related to a problem?

In nixpkgs we try to use the latest python packages. I noticed that most of the snapshot tests are failing when trying to use memray 1.15.0 with textual 2.0.0.

Here are the snapshot test results: https://gist.github.com/gepbird/a9b29ca97046ab5351867b72b6d7b955
Looks like some colors have changed (eg. red "Table updates paused" instead of orange), but a regression is icons not being resolved (eg. :compass: instead of 🧭 ).

Describe the solution you'd like

Bump textual and figure out why were the icons not resolved, update the snapshot tests.

Alternatives you considered

Temporarily disabling tests on our side.

@gepbird gepbird added the enhancement New feature or request label Feb 16, 2025
@godlygeek
Copy link
Contributor

I've entered Textualize/textual#5545 to ask whether the loss of support for emoji shortcodes is intentional or not, since that will determine our path forward here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants