Bump keycloak theme to v2.1.0#2819
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the Keycloak theme download script to use the ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR updates the Keycloak login theme release.
Confidence Score: 4/5The changed artifact download path needs HTTP failure validation before merging.
apps/login/tools/getBluedotKeycloakTheme.sh Important Files Changed
Reviews (1): Last reviewed commit: "Bump keycloak version" | Re-trigger Greptile |
| cd $(dirname "${BASH_SOURCE[0]:-$0}")/.. | ||
|
|
||
| FIXED_RELEASE_VERSION="v2.0.0" | ||
| FIXED_RELEASE_VERSION="v2.1.0" |
There was a problem hiding this comment.
Invalid Release Asset Passes Download
This new pin changes the artifact URL used by every login build, but the downloader accepts HTTP error responses because its curl call lacks --fail. If the v2.1.0 asset is temporarily unavailable or has a different filename, the response body is saved as the provider JAR and reaches the Keycloak image build, which can fail during build or startup instead of stopping at the download.
Description
Bumps keycloak theme to v2.1.0
Notable changes:
Issue
Fixes #2723