Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PR Previews #2

Open
ES-Alexander opened this issue Oct 10, 2024 · 0 comments
Open

Allow PR Previews #2

ES-Alexander opened this issue Oct 10, 2024 · 0 comments

Comments

@ES-Alexander
Copy link
Collaborator

Following on from #1, our current attempted preview mechanism doesn't work.

For context:

PRs (logically, in hindsight) normally cannot access secrets, so we need to put some more thought into how we want to generate previews in a safe manner.

Generating and uploading an Artifact seems like a viable first step, but because that doesn't host the docs it's a bit cumbersome. Following the github security resources that's the first step for limiting untrusted access anyway, and then we likely want to upload to a separate AWS bucket, potentially with extra restrictions on what kind of actions the files can perform (e.g. we may wish to restrict javascript to prevent malicious code execution for testers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant