You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would help with #122, and would also better enable data processing capabilities.
Should probably be implemented as a water.py module, with a helper for estimating salinity as per here. Ideally there would be some kind of API access to NASA's global sea surface salinity data (queried by GPS location?) or something, but that is probably best left as a note/TODO for now.
Would be useful to include an estimate_v_sound(self, depth=None, temperature=None, salinity=None) method in PingDevice that uses water.estimate_sound_speed(depth, temperature, salinity), which can be updated over time to use the most up to date implemented method. PingDevice can have its initialisation updated to include initial depth=0, temperature=25, salinity=water.estimate_salinity_from_type("seawater") values.
The text was updated successfully, but these errors were encountered:
Would help with #122, and would also better enable data processing capabilities.
Should probably be implemented as a
water.py
module, with a helper for estimating salinity as per here. Ideally there would be some kind of API access to NASA's global sea surface salinity data (queried by GPS location?) or something, but that is probably best left as a note/TODO for now.Example
v_sound
code at bluerobotics/ping-viewer/issues/1003Would be useful to include an
estimate_v_sound(self, depth=None, temperature=None, salinity=None)
method inPingDevice
that useswater.estimate_sound_speed(depth, temperature, salinity)
, which can be updated over time to use the most up to date implemented method.PingDevice
can have its initialisation updated to include initialdepth=0, temperature=25, salinity=water.estimate_salinity_from_type("seawater")
values.The text was updated successfully, but these errors were encountered: