Fix iOS JS status bar being ignored until the lightbox opens (#12339)

Author: mozzius

patches/react-native-pager-view@9.0.11.patch

@@ -26,3 +26,37 @@ index 56ec98a3be31a328d320dfde3237cb4a058af1f6..015bebfbf0bea5a6eefc4357984e1697
          }
 
          if scrollDelegate.originalDelegate == nil {
+diff --git a/ios/PagerViewProvider.swift b/ios/PagerViewProvider.swift
+index 87def2acf1bfb83fa79ff34a1537cac6afee3752..1e97045531befc80114f7c6f5959a99cbcd05ebd 100644
+--- a/ios/PagerViewProvider.swift
++++ b/ios/PagerViewProvider.swift
+@@ -74,6 +74,8 @@ final class PagerViewProvider: UIView, RNCPagerViewProviding {
+     super.didMoveToWindow()
+     if window != nil {
+       setupView()
++    } else {
++      detachFromParentViewController()
+     }
+   }
+ 
+@@ -240,6 +242,20 @@ final class PagerViewProvider: UIView, RNCPagerViewProviding {
+     hostingController.didMove(toParent: parentViewController)
+   }
+ 
++  /// Off-window, the hosting controller must not stay a child of the view
++  /// controller it was attached to. Otherwise an unmounted (or recycled) pager
++  /// leaves it behind, often on the root view controller, which changes what
++  /// UIKit and libraries that inspect `children` see (for example the status
++  /// bar delegation in react-native-screens). It is re-attached by
++  /// `willMove(toWindow:)` / `setupView()` when the pager is back in a window.
++  private func detachFromParentViewController() {
++    guard let hostingController, hostingController.parent != nil else {
++      return
++    }
++    hostingController.willMove(toParent: nil)
++    hostingController.removeFromParent()
++  }
++
+   /// SwiftUI can recreate the page controller around this React view while
+   /// preserving the view itself. Keep the hosting controller attached to the
+   /// current page controller so UIKit's view-controller hierarchy stays valid.

patches/react-native-pager-view@9.0.11.patch.md

@@ -1,6 +1,6 @@
 # react-native-pager-view+9.0.11.patch
 
-Carries one iOS change, in `ios/PagerView.swift`. Drop it once a release
+Carries two iOS changes. Drop each one once a release
 contains it.
 
 These upstream PRs were carried here until they shipped:
@@ -32,3 +32,21 @@ This can't be fixed from JS. react-native-screens re-applies the option only
 when the screen attaches or the prop changes, and RN views do not trigger
 UIKit's edge effect. Drop this part if upstream adds a prop to keep the top
 edge effect.
+
+## iOS: detach the hosting controller when the pager leaves the window
+
+Backport of the `didMoveToWindow` hunk of upstream PR
+https://github.com/callstack/react-native-pager-view/pull/1204 (released in
+10.0.0). Drop it when we upgrade to 10.x.
+
+In 9.0.11 the pager's `UIHostingController` is added as a child of
+`reactViewController()` and never removed, only re-parented. The lightbox
+pager sits outside the navigation stack, so after the first lightbox open the
+root view controller keeps a leaked hosting controller as its last child.
+
+That matters because react-native-screens' status bar swizzle only delegates to
+its own view controllers when one is the root's *last* child. The leak changed
+which view controller UIKit asked for the status bar style for the rest of the
+session (it made the JS status bar start working, and would make RNS screen
+status bar options stop working). With the detach, the root's children no
+longer depend on whether the lightbox has been opened.

patches/react-native-screens@4.30.1.patch

@@ -470,7 +470,7 @@ index 0000000000000000000000000000000000000000..7498c7aea5a853ad12ea607cce921d47
 +
 +} // namespace rnscreens
 diff --git a/ios/RNSScreen.mm b/ios/RNSScreen.mm
-index 049fd22427b2bde17fd7ca59b8de65d0ee07b4b5..ac484f9033e16f61fb382ed266eac8c3d6fe8b74 100644
+index 049fd22427b2bde17fd7ca59b8de65d0ee07b4b5..a1597db71b69de1c2db87ddf9f825aa51850f2e7 100644
 --- a/ios/RNSScreen.mm
 +++ b/ios/RNSScreen.mm
 @@ -1,4 +1,5 @@
@@ -479,7 +479,15 @@ index 049fd22427b2bde17fd7ca59b8de65d0ee07b4b5..ac484f9033e16f61fb382ed266eac8c3
 
  #import "RNSModalScreen.h"
  #import "RNSScreen.h"
-@@ -1226,9 +1227,82 @@ - (BOOL)hasHeaderConfig
+@@ -10,6 +11,7 @@
+ #import <React/RCTFabricComponentsPlugins.h>
+ #import <React/RCTRootComponentView.h>
+ #import <React/RCTScrollViewComponentView.h>
++#import <React/RCTStatusBarAppearance.h>
+ #import <React/RCTSurfaceTouchHandler.h>
+ #import <react/renderer/components/rnscreens/EventEmitters.h>
+ #import <react/renderer/components/rnscreens/Props.h>
+@@ -1226,9 +1228,82 @@ - (BOOL)hasHeaderConfig
    return _config != nil;
  }
 
@@ -562,7 +570,39 @@ index 049fd22427b2bde17fd7ca59b8de65d0ee07b4b5..ac484f9033e16f61fb382ed266eac8c3
  }
 
  + (react::ComponentDescriptorProvider)componentDescriptorProvider
-@@ -2110,6 +2184,12 @@ - (RNSOrientation)evaluateOrientation
+@@ -1955,7 +2030,8 @@ - (UIViewController *)childViewControllerForStatusBarHidden
+ 
+ - (BOOL)prefersStatusBarHidden
+ {
+-  return self.screenView.statusBarHidden;
++  // A screen without the prop defers to the status bar set from JS.
++  return self.screenView.hasStatusBarHiddenSet ? self.screenView.statusBarHidden : RCTStatusBarAppearance.hidden;
+ }
+ 
+ - (UIViewController *)childViewControllerForStatusBarStyle
+@@ -1966,7 +2042,10 @@ - (UIViewController *)childViewControllerForStatusBarStyle
+ 
+ - (UIStatusBarStyle)preferredStatusBarStyle
+ {
+-  return [RNSScreenWindowTraits statusBarStyleForRNSStatusBarStyle:self.screenView.statusBarStyle];
++  // A screen without the prop defers to the status bar set from JS.
++  return self.screenView.hasStatusBarStyleSet
++      ? [RNSScreenWindowTraits statusBarStyleForRNSStatusBarStyle:self.screenView.statusBarStyle]
++      : RCTStatusBarAppearance.style;
+ }
+ 
+ - (UIStatusBarAnimation)preferredStatusBarUpdateAnimation
+@@ -1976,7 +2055,8 @@ - (UIStatusBarAnimation)preferredStatusBarUpdateAnimation
+   if ([vc isKindOfClass:[RNSScreen class]]) {
+     return ((RNSScreen *)vc).screenView.statusBarAnimation;
+   }
+-  return UIStatusBarAnimationFade;
++  // No screen sets the animation, so use the one set from JS.
++  return RCTStatusBarAppearance.updateAnimation;
+ }
+ 
+ - (UIInterfaceOrientationMask)supportedInterfaceOrientations
+@@ -2110,6 +2190,12 @@ - (RNSOrientation)evaluateOrientation
 
  - (void)addSnapshotToView
  {
@@ -575,7 +615,7 @@ index 049fd22427b2bde17fd7ca59b8de65d0ee07b4b5..ac484f9033e16f61fb382ed266eac8c3
    // if we dismissed the view natively, it will already be detached from view hierarchy
    if (self.view.window == nil) {
      return;
-@@ -2123,6 +2203,13 @@ - (void)addSnapshotToView
+@@ -2123,6 +2209,13 @@ - (void)addSnapshotToView
    snapshot.frame = self.view.bounds;
    // fill the whole screen view with the snapshot
    snapshot.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;

patches/react-native-screens@4.30.1.patch.md

@@ -57,6 +57,35 @@ frames are in the screen view's coordinates, which match the snapshot's. They
 are now also released when the view has already left the window and no
 snapshot is taken. The 4.30.0 port hasn't been re-run against the repro.
 
+## iOS: screens without status bar props defer to the JS status bar
+
+Port of upstream PR
+https://github.com/software-mansion/react-native-screens/pull/5135 (open, not
+in a release as of 4.30.1).
+
+With `UIViewControllerBasedStatusBarAppearance = YES`, React Native 0.88.1
+stores `<StatusBar>` / `StatusBar.pushStackEntry` values in
+`RCTStatusBarAppearance` and expects the root view controller to return them
+(`ExpoRootViewController` does). But `UIViewController+RNScreens.mm` swizzles
+`childViewControllerForStatusBarStyle/Hidden` on every view controller: when
+the root's last child is an RNS controller, UIKit asks the top `RNSScreen`
+instead, which returned hard-coded defaults (`Auto` style following the system
+appearance, not hidden, `Fade`). So every JS status bar change was ignored on
+iOS, e.g. the light status bar over profile banners, and the app theme when it
+differs from the system appearance.
+
+It only showed from a cold start. Opening the lightbox leaked pager-view's
+hosting controller onto the root view controller, so the root's last child was
+no longer an RNS controller and the swizzle fell through. See the pager-view
+patch. Debug dev-client builds also hide it, because the dev launcher puts a
+non-RNS view controller in the chain, so verify in a Release build.
+
+The patch makes `RNSScreen` fall back to `RCTStatusBarAppearance` for each
+trait the screen doesn't set. A screen that sets `statusBarStyle` /
+`statusBarHidden` / `statusBarAnimation` still wins. We set none of them, so
+for us the JS status bar always applies. Verified in a Release build on an
+iOS 27.2 simulator (Xcode 27.2): broken before, fixed after.
+
 ## iOS + Android: do not dirty shadow nodes' Yoga nodes on every clone
 
 Several component descriptors call `YogaLayoutableShadowNode::setSize()` from