Skip to content

Fix followed by chat invites - #10873

Merged
mozzius merged 1 commit into
mainfrom
d/chat-followed-by
Jun 11, 2026
Merged

mozzius merged 1 commit into
mainfrom
d/chat-followed-by

Conversation

@ds-boyce

Copy link
Copy Markdown
Contributor

Got this exactly backwards.

@ds-boyce
ds-boyce requested a review from mozzius June 11, 2026 17:54
@github-actions

Copy link
Copy Markdown
Contributor
Old size New size Diff
7.76 MB 7.76 MB 2 B (0.00%)

@mozzius mozzius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's right now. @claude please confirm

@linear-code

linear-code Bot commented Jun 11, 2026

Copy link
Copy Markdown

APP-2393

@claude

claude Bot commented Jun 11, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @mozzius's task in 32s —— View job


Confirmation ✅

I reviewed both changes against the followedByOwner join rule logic, and the fix is correct.

The reasoning:

The join rule is followedByOwner — meaning the chat owner must follow you in order for you to join (gate at Root.tsx:124 and GroupChatJoinDialog.tsx:303):

} else if (preview.joinRule === 'followedByOwner' && !isFollowing) {
  // "Only people the chat owner follows can join"
}

On owner.viewer, the two fields mean:

  • following → you follow the owner
  • followedBy → the owner follows you

Since the rule is "people the chat owner follows", the correct field is followedBy. The previous following had it exactly backwards, as the PR title says. ✅

Both call sites (ChatInvite/Root.tsx:84 and GroupChatJoinDialog.tsx:288) are updated consistently.

Minor nit (non-blocking): the variable is still named isFollowing, which now reads slightly misleadingly since it actually represents "is followed by the owner." Renaming to something like isFollowedByOwner would make the intent clearer, but it's purely cosmetic and not necessary for this fix.
• d/chat-followed-by

@mozzius
mozzius merged commit d57eeb9 into main Jun 11, 2026
20 checks passed
@ds-boyce
ds-boyce deleted the d/chat-followed-by branch June 11, 2026 18:05
mozzius pushed a commit that referenced this pull request Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants