You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed both changes against the followedByOwner join rule logic, and the fix is correct.
The reasoning:
The join rule is followedByOwner — meaning the chat owner must follow you in order for you to join (gate at Root.tsx:124 and GroupChatJoinDialog.tsx:303):
}elseif(preview.joinRule==='followedByOwner'&&!isFollowing){// "Only people the chat owner follows can join"}
On owner.viewer, the two fields mean:
following → you follow the owner
followedBy → the owner follows you
Since the rule is "people the chat owner follows", the correct field is followedBy. The previous following had it exactly backwards, as the PR title says. ✅
Both call sites (ChatInvite/Root.tsx:84 and GroupChatJoinDialog.tsx:288) are updated consistently.
Minor nit (non-blocking): the variable is still named isFollowing, which now reads slightly misleadingly since it actually represents "is followed by the owner." Renaming to something like isFollowedByOwner would make the intent clearer, but it's purely cosmetic and not necessary for this fix.
• d/chat-followed-by
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got this exactly backwards.