remove excess type checking

Author: josephhanrahan

src/blop/ax/optimizer.py

@@ -230,22 +230,22 @@ def _apply_parameter_update(
 
         Raises
         ------
-        ValueError
+        TypeError
             If the provided value does not match the expected type for the parameter.
         """
         parameter = self._client._experiment.parameters[parameter_name]
         if isinstance(parameter, RangeParameter):
             if not isinstance(value, tuple):
-                raise ValueError(f"{RangeParameter.__name__} only accepts tuples of length 2, but got: {value}")
+                raise TypeError(f"{RangeParameter.__name__} only accepts tuples of length 2, but got: {value}")
             original_range_values[parameter_name] = (parameter.lower, parameter.upper)
             parameter.update_range(*value)
         elif isinstance(parameter, ChoiceParameter):
-            if not isinstance(value, list) or not all(isinstance(v, type(parameter.values[0])) for v in value):
-                raise ValueError(f"{ChoiceParameter.__name__} only accepts list of items, but got: {value}")
+            if not isinstance(value, list):
+                raise TypeError(f"{ChoiceParameter.__name__} only accepts list of items, but got: {value}")
             original_choice_values[parameter_name] = parameter.values
             parameter.set_values(value)
         else:
-            raise ValueError(f"Expected RangeParameter or ChoiceParameter, but got {parameter}")
+            raise TypeError(f"Expected RangeParameter or ChoiceParameter, but got {parameter}")
 
     def _rollback_parameter_updates(
         self,

src/blop/tests/ax/test_optimizer.py

@@ -199,13 +199,13 @@ def test_ax_optimizer_reconfigurable_search_space():
     with pytest.raises(KeyError):
         optimizer._reconfigure_search_space({"x4": (-4, 4)})
     # ChoiceParameter expects a list
-    with pytest.raises(ValueError):
+    with pytest.raises(TypeError):
         optimizer._reconfigure_search_space({"x3": 3})
-    # ChoiceParameter expects a list of single type
+    # ChoiceParameter expects a list of types castable to parameter_type
     with pytest.raises(ValueError):
-        optimizer._reconfigure_search_space({"x3": ["2", 5, 3.6]})
+        optimizer._reconfigure_search_space({"x3": ["2", "Hello", 3.6]})
     # RangeParameter expects a tuple
-    with pytest.raises(ValueError):
+    with pytest.raises(TypeError):
         optimizer._reconfigure_search_space({"x1": 3})
 
     # Changing the serach space should reflect in parameter state