Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 0.4.0 causes problem with lightbox #41

Open
Laserlicht opened this issue May 11, 2024 · 1 comment
Open

New version 0.4.0 causes problem with lightbox #41

Laserlicht opened this issue May 11, 2024 · 1 comment

Comments

@Laserlicht
Copy link

Laserlicht commented May 11, 2024

Has to revert to older version (0.3.7): vcmi/VCMI.eu#34

Because the lightbox only works for cached images. If you open a uncached page: When you click on image you will see the spinner forever an the image isn't loading.

Now, after revert it's working just fine again.

Web console also generates an error:

Uncaught TypeError: URL constructor:  is not a valid URL.
    Xa index.ts:110
    i index.ts:301
    RxJS 7
12 [index.ts:110:6](https://vcmi.eu/assets/javascripts/src/templates/assets/javascripts/integrations/instant/index.ts)

It seems a href url is unset.

I'm not sure if this bug is coming from this library. Or from https://github.com/squidfunk/mkdocs-material by @squidfunk

@Laserlicht Laserlicht changed the title New versions causes problem with lightbox New version 3.4.0 causes problem with lightbox May 11, 2024
@Laserlicht Laserlicht changed the title New version 3.4.0 causes problem with lightbox New version 0.4.0 causes problem with lightbox May 11, 2024
@odin568
Copy link

odin568 commented Sep 5, 2024

Having same issue. Downgrade to 0.3.7 helps, but not a solution of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants