Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/file upload #162

Closed

Conversation

SajanGhuman
Copy link
Contributor

This PR fixes file uploading functionality with proper error logging.

  • File uploads
  • File size cannot be more than 1 MB
  • File and metadata is saved to the database
  • Rollback logic, In case upload fails

upload_success
upload_failed

@SajanGhuman SajanGhuman added Backend Backend Related Issue UX/UI Change Highlights changes affecting user experience or interface design labels Jan 14, 2025
@SajanGhuman SajanGhuman added this to the 1.0 milestone Jan 14, 2025
@SajanGhuman SajanGhuman requested a review from mahid797 January 14, 2025 14:47
@SajanGhuman SajanGhuman self-assigned this Jan 14, 2025
@gorkem-bwl
Copy link
Contributor

Can you make the file size more than 1Mb? I believe there are several cases where even 20Mb PDF files are around. Unless it has complex layouts, high-resolution images, or embedded media, 20Mb should be sufficient, so 20Mb should be good for now.

@SajanGhuman
Copy link
Contributor Author

Can you make the file size more than 1Mb? I believe there are several cases where even 20Mb PDF files are around. Unless it has complex layouts, high-resolution images, or embedded media, 20Mb should be sufficient, so 20Mb should be good for now.

Yes, we just need to change one variable for that to happen. It is just that supabase has limited storage so we kept it at 1MB which can changed easily.

@mahid797 mahid797 linked an issue Jan 15, 2025 that may be closed by this pull request
6 tasks
@mahid797 mahid797 added the Question Further information is requested label Jan 15, 2025
@mahid797 mahid797 modified the milestones: v0.1.0-alpha, v0.1 Feb 18, 2025
Copy link
Collaborator

@mahid797 mahid797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SajanGhuman

  • Could you update this to use TanStack Query?
  • Please use a fresh clone of the repo and make sure to check out the dev branch (not master). Also, make sure the PR is targeting dev, not master.
  • Also, please contribute directly to the repo instead of using a fork.

Closing this PR for now.

@mahid797 mahid797 closed this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Backend Related Issue Question Further information is requested UX/UI Change Highlights changes affecting user experience or interface design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Batch File Uploads
3 participants