fixes saxix#206. new AUTO_CREATE_TRIGGERS

Author: saxix

docs/settings.rst

@@ -11,6 +11,21 @@ default values.
 .. note:: Each entry **MUST** have the prefix ``CONCURRENCY_`` when used in your settings.py
 
 
+.. setting:: CONCURRENCY_AUTO_CREATE_TRIGGERS
+
+AUTO_CREATE_TRIGGERS
+--------------------
+.. versionadded:: 2.3
+
+Default: ``True``
+
+If true automatically create triggers.
+To manually create triggers set `CONCURRENCY_AUTO_CREATE_TRIGGERS=False` and use :ref:`triggers`
+ management command or create them manually using your DB client.
+
+Note:: This flag deprecate :ref:`MANUAL_TRIGGERS`
+
+
 .. setting:: CONCURRENCY_ENABLED
 
 ENABLED
@@ -102,6 +117,7 @@ numbers to pass concurrency checks.
 MANUAL_TRIGGERS
 ---------------
 .. versionadded:: 1.0
+.. deprecated:: 2.3
 
 Default: ``False``
 

setup.py

@@ -54,13 +54,11 @@ def run_tests(self):
         'Development Status :: 5 - Production/Stable',
         'Environment :: Web Environment',
         'Intended Audience :: Developers',
-        'License :: OSI Approved :: BSD License',
+        'License :: OSI Approved :: MIT License',
         'Operating System :: OS Independent',
         'Programming Language :: Python',
-        'Framework :: Django :: 1.11',
-        'Framework :: Django :: 2.1',
-        'Framework :: Django :: 2.2',
         'Framework :: Django :: 3.0',
+        'Framework :: Django :: 3.1',
         'Programming Language :: Python :: 3',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',

src/concurrency/config.py

@@ -1,3 +1,5 @@
+import warnings
+
 from django.core.exceptions import ImproperlyConfigured
 from django.test.signals import setting_changed
 
@@ -18,7 +20,8 @@
 class AppSettings(object):
     defaults = {
         'ENABLED': True,
-        'MANUAL_TRIGGERS': False,
+        'AUTO_CREATE_TRIGGERS': True,
+        'MANUAL_TRIGGERS': False,  # deprecated: use AUTO_CREATE_TRIGGERS
         'FIELD_SIGNER': 'concurrency.forms.VersionFieldSigner',
         'POLICY': CONCURRENCY_LIST_EDITABLE_POLICY_SILENT,
         'CALLBACK': 'concurrency.views.callback',
@@ -58,6 +61,10 @@ def _set_attr(self, prefix_name, value):
                     "{} is not a valid value for `CALLBACK`. It must be a callable or a fullpath to callable. ".format(
                         value))
             self._callback = func
+        elif name == "MANUAL_TRIGGERS":
+            warnings.warn("MANUAL_TRIGGERS is deprecated and will be removed in 2.5. Use AUTO_CREATE_TRIGGERS",
+                          category=DeprecationWarning)
+            self.AUTO_CREATE_TRIGGERS = not value
 
         setattr(self, name, value)
 

tests/conftest.py

@@ -26,6 +26,8 @@ def pytest_configure():
 
     settings.SILENCED_SYSTEM_CHECKS = ['concurrency.W001']
     settings.CONCURRENCY_VERSION_FIELD_REQUIRED = False
+    settings.CONCURRENCY_MANUAL_TRIGGERS = False
+    settings.CONCURRENCY_AUTO_CREATE_TRIGGERS = True
 
 
 @pytest.fixture(scope='session')

tests/test_admin_list_editable.py

@@ -29,10 +29,9 @@ def _create_conflict(self, pk):
 
     def test_normal_add(self):
         res = self.app.get('/admin/', user='sax')
-
+        # file:///admin/demo/listeditableconcurrentmodel/add/
         res = res.click(self.TARGET._meta.verbose_name_plural)
-
-        res = res.click('Add', href='/admin/auth/user/add/')
+        res = res.click('Add', href=f'/admin/demo/{self.TARGET._meta.model_name}/add/')
         form = res.form
         form['username'] = 'CHAR'
         res = form.submit().follow()

tests/test_api.py

@@ -13,7 +13,7 @@
 
 
 @pytest.mark.django_db(transaction=False)
-@pytest.mark.skipIf('os.environ["DBENGINE"]=="pg"')
+@pytest.mark.skipif('os.environ.get("DBENGINE", "")=="pg"')
 def test_get_revision_of_object(model_class=SimpleConcurrentModel):
     instance = model_class(username=next(nextname))
     instance.save()

tox.ini

@@ -22,6 +22,7 @@ addopts =
 pep8ignore = * ALL
 markers =
   functional: mark a test as functional
+  admin:  admin tests
 
 [testenv]
 ;install_command=pip install {opts} {packages}