Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rooter to own crate #156

Closed
kanongil opened this issue Sep 7, 2023 · 6 comments
Closed

Move rooter to own crate #156

kanongil opened this issue Sep 7, 2023 · 6 comments

Comments

@kanongil
Copy link

kanongil commented Sep 7, 2023

I'm using libunftp and have developed a custom auth integration against Auth0. It authorises the user and returns the location of the user's dir on the local FS. However, there is no simple way to change the served dir.

I see that the unFTP storage/rooter.rs already handles this, and was wondering if you could move it to it's own crate that everyone can use?

FYI, the storage/restrict.rs module could probably be useful as an independent module as well, eg. to enable readonly access for the user.

@hannesdejager
Copy link
Collaborator

Hi @kanongil , this is super 🦸‍♂️ and indeed in my mind I planned to move these 2 out to their own crates. Let me see if I can do this over the week-end for you.

Thank you for helping further our vision as described here. You came as if you were sent!

Screenshot 2023-09-08 at 08 44 56

The Auth0 authenticator is especially one that I'd love to see out there. If you plan to move it to its own crate consider using our naming convention described in the contribution guide here.

@kanongil
Copy link
Author

kanongil commented Sep 8, 2023

Cool. This is my first real rust project, so I'm not sure how far I will take it, but creating a version that can be published for others to use is definitely in my thoughts. At least I'm used to publishing / supporting node.js modules, so that part won't be all new.

@hannesdejager
Copy link
Collaborator

Hi @kanongil, see here: https://crates.io/crates/unftp-sbe-rooter

Does it work for you?

@kanongil
Copy link
Author

Awesome! Yes, it works as expected – thanks for the quick turnaround 👍

@hannesdejager
Copy link
Collaborator

@kanongil great to hear! The documentation is lacking still

@hannesdejager
Copy link
Collaborator

I've split out the restrict.rs module to. See here: https://crates.io/crates/unftp-sbe-restrict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants