Setting Capacity property in GraphPanel node does not work

[ncguilbeault]

It seems that setting the Capacity property in the GraphPanel node doesn't work.

Steps to reproduce: Compose a LineGraph onto a GraphPanel and explicitly set the Capacity property of the GraphPanel. The capacity will change on the visualizer window, but the series data do not reflect this.

Interestingly, setting the capacity to a value using the toolbox inside of the visualizer window does work, so long as the capacity property of the node remains empty.

[banchan86]

additional report from https://github.com/orgs/bonsai-rx/discussions/2085 - Span might also not work.

[ZegCricket]

It seems the same issue is happening in the RollingGraphPanel node.

[ZegCricket]

I'm not sure if what I'm going to say should be here or on a new discussion/issue, but I noted that the RollingGraphPanel doesn't replicate the behavior of the RollingGraph. I don't know which one is incorrect (or if I'm the one not using it correctly) and I don't think I can explain it in a good way, so here is an example where it's easy to understand what I mean:

<?xml version="1.0" encoding="utf-8"?>
<WorkflowBuilder Version="2.8.5"
                 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                 xmlns:rx="clr-namespace:Bonsai.Reactive;assembly=Bonsai.Core"
                 xmlns:num="clr-namespace:Bonsai.Numerics;assembly=Bonsai.Numerics"
                 xmlns:zg="clr-namespace:Bonsai.Gui.ZedGraph;assembly=Bonsai.Gui.ZedGraph"
                 xmlns="https://bonsai-rx.org/2018/workflow">
  <Workflow>
    <Nodes>
      <Expression xsi:type="Combinator">
        <Combinator xsi:type="rx:Timer">
          <rx:DueTime>PT0S</rx:DueTime>
          <rx:Period>PT1S</rx:Period>
        </Combinator>
      </Expression>
      <Expression xsi:type="Combinator">
        <Combinator xsi:type="num:Sin" />
      </Expression>
      <Expression xsi:type="Combinator">
        <Combinator xsi:type="num:Cos" />
      </Expression>
      <Expression xsi:type="Combinator">
        <Combinator xsi:type="rx:Zip" />
      </Expression>
      <Expression xsi:type="zg:RollingGraphBuilder">
        <zg:IndexSelector>Item1</zg:IndexSelector>
        <zg:ValueSelector>Item2</zg:ValueSelector>
        <zg:SymbolType>None</zg:SymbolType>
        <zg:LineWidth>1</zg:LineWidth>
        <zg:CurveSettings />
        <zg:Capacity xsi:nil="true" />
        <zg:Min xsi:nil="true" />
        <zg:Max xsi:nil="true" />
      </Expression>
      <Expression xsi:type="VisualizerMapping" />
      <Expression xsi:type="zg:RollingGraphPanelBuilder">
        <zg:ReverseX>false</zg:ReverseX>
        <zg:ReverseY>false</zg:ReverseY>
        <zg:Span xsi:nil="true" />
        <zg:Capacity xsi:nil="true" />
        <zg:BaseAxis>X</zg:BaseAxis>
        <zg:BarType>Cluster</zg:BarType>
        <zg:Min xsi:nil="true" />
        <zg:Max xsi:nil="true" />
      </Expression>
    </Nodes>
    <Edges>
      <Edge From="0" To="1" Label="Source1" />
      <Edge From="0" To="2" Label="Source1" />
      <Edge From="1" To="3" Label="Source1" />
      <Edge From="2" To="3" Label="Source2" />
      <Edge From="3" To="4" Label="Source1" />
      <Edge From="4" To="5" Label="Source1" />
      <Edge From="5" To="6" Label="Source1" />
    </Edges>
  </Workflow>
</WorkflowBuilder>

Thank you in advance and sorry if I posted this on the wrong place!

[banchan86]

Not sure what is going on there but wow the RollingGraphPanel graph is very pretty!

I will note that if you just want to replicate the RollingGraph in a layout you can use TableLayoutPanel instead. My feeling is that RollingGraphPanel is meant to be used in a different way, but I need to play around with it a little more.

[ZegCricket]

If you look at the x-axis of the first graph (RollingGraph), you see that the graph is treated as a time series, but in which the label corresponds to the x-value. However, the second graph (RollingGraphPanel) plots the points "correctly".

I thought the idea of RollingGraphPanel was just to be able to put multiple RollingGraphs in the same plot. If this was the case, I could make use of the "time-series way" RollingGraph deals with data to partially solve my problem of not being able to reset plots in a GUI, like already discussed here. For my particular use case, it's important to be able to plot multiple things in the same figure, that's why I came across this problem.

Thanks again, @banchan86! :)

[banchan86]

Ah yea I see it now thanks for the explanation! As far as I can tell from going through some of the videos from the Bonsai Conference where this package was displayed (but I might be wrong):

1. RollingGraph should always display as sort of a "timeseries", and its more meant to plot an observable streams that unfolds over time/as elements are received.

2. In your RollingGraphPanel graph, its something more akin to like LineGraph. In fact you can recreate the same graph with:

3. RollingGraphPanel is supposed to overlay multiple RollingGraphs on the same graph/axis and i'm not sure its working as intended in your example (might be a bug). I am also not sure if the name might convey the right usage or if something like RollingGraphOverlay might be better. This is how i think it was intended to be used:

In any case, I think its worth raising as a separate issue, I can write it up later with the points here.

Attached the workflow that I played around with.

+GUI #33 RollingGraphPanel.zip

[ZegCricket]

Thank you so much for the quick replies, @banchan86! Let me know if I can help with anything!

[banchan86]

No worries, I just opened the issue if you wish to follow up on it, thanks for the report!