enforce lower-case naming for slash command option names

Author: ashishjh-bst

customcommands/assets/customcommands-editcmd.html

@@ -1236,13 +1236,15 @@ <h2 class="card-title">Custom Command Information</h2>
             const nIn = row.querySelector('[data-slash-field="name"]');
             const dIn = row.querySelector('[data-slash-field="description"]');
             const tSel = row.querySelector('[data-slash-field="type"]');
-            const raw = (nIn ? nIn.value : '').trim();
-            if (raw === '') return; // blank rows are dropped server-side
-            const oname = raw.toLowerCase();
+            const oname = (nIn ? nIn.value : '').trim();
+            if (oname === '') return; // blank rows are dropped server-side
             const label = 'argument "' + oname + '"';
 
             if (!SLASH_NAME_RE.test(oname)) {
-                errors.push('Argument name "' + raw + '" must be 1-32 characters: letters, numbers, dashes and underscores.');
+                errors.push('Argument name "' + oname + '" must be 1-32 characters: letters, numbers, dashes and underscores.');
+                slashMark(nIn, true);
+            } else if (oname !== oname.toLowerCase()) {
+                errors.push('Argument name "' + oname + '" must be lowercase.');
                 slashMark(nIn, true);
             }
             if (seen[oname]) {

customcommands/customcommands.go

@@ -532,9 +532,13 @@ func validateSlashCommandData(guildID int64, name, description string, options [
 
 	seenOptions := make(map[string]bool, len(options))
 	for _, opt := range options {
-		oname := strings.ToLower(strings.TrimSpace(opt.Name))
+		oname := strings.TrimSpace(opt.Name)
 		if !slashCommandNameRegex.MatchString(oname) {
-			return false, fmt.Sprintf("Option name %q must be 1-32 lowercase characters (letters, numbers, dashes, underscores)", opt.Name)
+			return false, fmt.Sprintf("Option name %q must be 1-32 characters (letters, numbers, dashes, underscores)", opt.Name)
+		}
+
+		if oname != strings.ToLower(oname) {
+			return false, fmt.Sprintf("Option name %q must be lowercase", opt.Name)
 		}
 		if seenOptions[oname] {
 			return false, fmt.Sprintf("Duplicate option name %q", oname)