Fixed #169

Author: boxuancui

NEWS.md

@@ -3,6 +3,7 @@
 * [#181](https://github.com/boxuancui/DataExplorer/issues/181): Added `by` argument to `plot_histogram` and `plot_density` to break down distributions by a discrete or continuous feature.
 
 ## Bug Fixes
+* [#169](https://github.com/boxuancui/DataExplorer/issues/169): Charts no longer run off the edge of PDF pages. Report template now uses smaller figure dimensions (6" x 6") for PDF output and keeps larger dimensions (14" x 10") for HTML.
 * [#172](https://github.com/boxuancui/DataExplorer/issues/172): Fixed `plot_qq(..., by = ...)` error "Faceting variables must have at least one value".
 * [#185](https://github.com/boxuancui/DataExplorer/issues/185): Fixed warnings from deprecated `aes_string`.
 

R/create_report.R

@@ -103,8 +103,15 @@ create_report <- function(data,
   }
   ## Get directory of report markdown template
   report_dir <- system.file("rmd_template/report.rmd", package = "DataExplorer")
-  ## Render report into html
-  suppressWarnings(render(
+  ## When output format is PDF, ensure output_file has .pdf extension
+  is_pdf <- identical(output_format, "pdf_document") ||
+    "pdf_document" %in% class(output_format) ||
+    (is.list(output_format) && !is.null(output_format$pandoc$to) && grepl("^latex", output_format$pandoc$to))
+  if (is_pdf && !grepl("\\.pdf$", output_file, ignore.case = TRUE)) {
+    output_file <- paste0(sub("\\.[^.]+$", "", output_file), ".pdf")
+  }
+  ## Render report
+  report_path <- suppressWarnings(render(
     input = report_dir,
     output_format = output_format,
     output_file = output_file,
@@ -113,7 +120,6 @@ create_report <- function(data,
     params = list(data = data, report_config = config, response = y, set_title = report_title),
     ...
   ))
-  ## Open report
-  report_path <- path.expand(file.path(output_dir, output_file))
-  browseURL(report_path)
+  ## Open report (use path returned by render in case extension was normalized)
+  browseURL(path.expand(report_path))
 }

inst/rmd_template/report.rmd

@@ -14,10 +14,15 @@ library(data.table)
 library(rmarkdown)
 library(knitr)
 
-## Set knitr options
+## Set knitr options (smaller figures for PDF so charts fit on page; see #169)
+fig_dims <- if (knitr::is_latex_output()) {
+  list(fig.width = 6, fig.height = 6)
+} else {
+  list(fig.width = 14, fig.height = 10)
+}
 opts_chunk$set(
-  fig.width = 14,
-  fig.height = 10,
+  fig.width = fig_dims$fig.width,
+  fig.height = fig_dims$fig.height,
   echo = FALSE,
   results = "asis",
   warning = TRUE