Address test-coverage #40 warnings and errors

Author: boxuancui

tests/testthat/helper-ggplot.R

@@ -0,0 +1,5 @@
+is_ggplot <- if (exists("is_ggplot", envir = asNamespace("ggplot2"), inherits = FALSE)) {
+  get("is_ggplot", envir = asNamespace("ggplot2"), inherits = FALSE)
+} else {
+  function(x) inherits(x, "ggplot")
+}

tests/testthat/test-create-report.R

@@ -20,13 +20,22 @@ test_that("test overall functionalities", {
                 output_file = file_name, output_dir = dir_name,
                 config = list("plot_correlation" = list(), "plot_prcomp" = list()),
                 report_title = "5/6: Detect 0 complete rows", quiet = TRUE)
-  create_report(airquality, y = "Ozone", plotly = TRUE, report_title = "6/6: Create report with plotly", quiet = TRUE)
   create_report(iris, output_file = file_name, output_dir = dir_name, quiet = TRUE)
   expect_true(file.exists(file_dir))
   expect_gte(file.info(file_dir)$size, 100000)
   if (file.exists(file_dir)) expect_true(file.remove(file_dir))
 })
 
+test_that("test create_report with plotly", {
+  skip_on_cran()
+  skip_if_not_installed("plotly")
+  create_report(airquality, y = "Ozone", plotly = TRUE,
+                output_file = file_name, output_dir = dir_name,
+                report_title = "6/6: Create report with plotly", quiet = TRUE)
+  expect_true(file.exists(file_dir))
+  if (file.exists(file_dir)) expect_true(file.remove(file_dir))
+})
+
 test_that("test if non-existing y throws an error", {
   skip_on_cran()
   expect_error(create_report(iris, y = "abc"))

tests/testthat/test-plot-bar.R

@@ -14,12 +14,12 @@ test_that("test return object", {
   plot_list <- plot_bar(diamonds)
   expect_is(plot_list, "list")
   expect_equal(names(plot_list), "page_1")
-  expect_true(is.ggplot(plot_list[[1]]))
+  expect_true(is_ggplot(plot_list[[1]]))
 
   plot_list2 <- plot_bar(diamonds, nrow = 1L, ncol = 1L)
   expect_is(plot_list2, "list")
   expect_equal(names(plot_list2), c("page_1", "page_2", "page_3"))
-  expect_true(all(vapply(plot_list2, is.ggplot, TRUE)))
+  expect_true(all(vapply(plot_list2, is_ggplot, TRUE)))
 })
 
 test_that("test binary categories", {

tests/testthat/test-plot-boxplot.R

@@ -8,10 +8,10 @@ test_that("test return object", {
   boxplot_list <- plot_boxplot(iris, by = "Species")
   expect_is(boxplot_list, "list")
   expect_equal(names(boxplot_list), "page_1")
-  expect_true(is.ggplot(boxplot_list[[1]]))
+  expect_true(is_ggplot(boxplot_list[[1]]))
 
   boxplot_list2 <- plot_boxplot(iris, by = "Species", nrow = 1L, ncol = 1L)
   expect_is(boxplot_list2, "list")
   expect_equal(names(boxplot_list2), c("page_1", "page_2", "page_3", "page_4"))
-  expect_true(all(vapply(boxplot_list2, is.ggplot, TRUE)))
+  expect_true(all(vapply(boxplot_list2, is_ggplot, TRUE)))
 })

tests/testthat/test-plot-correlation.R

@@ -19,5 +19,5 @@ test_that("test error messages", {
 
 test_that("test return object", {
 	plot_obj <- plot_correlation(iris)
-	expect_true(is.ggplot(plot_obj))
+	expect_true(is_ggplot(plot_obj))
 })

tests/testthat/test-plot-histogram-density.R

@@ -10,22 +10,22 @@ test_that("test return object", {
 	histogram_list <- plot_histogram(iris)
 	expect_is(histogram_list, "list")
 	expect_equal(names(histogram_list), "page_1")
-	expect_true(is.ggplot(histogram_list[[1]]))
+	expect_true(is_ggplot(histogram_list[[1]]))
 
 	histogram_list2 <- plot_histogram(iris, nrow = 1L, ncol = 1L)
 	expect_is(histogram_list2, "list")
 	expect_equal(names(histogram_list2), c("page_1", "page_2", "page_3", "page_4"))
-	expect_true(all(vapply(histogram_list2, is.ggplot, TRUE)))
+	expect_true(all(vapply(histogram_list2, is_ggplot, TRUE)))
 
 	density_list <- plot_density(iris)
 	expect_is(density_list, "list")
 	expect_equal(names(density_list), "page_1")
-	expect_true(is.ggplot(density_list[[1]]))
+	expect_true(is_ggplot(density_list[[1]]))
 
 	density_list2 <- plot_density(iris, nrow = 1L, ncol = 1L)
 	expect_is(density_list2, "list")
 	expect_equal(names(density_list2), c("page_1", "page_2", "page_3", "page_4"))
-	expect_true(all(vapply(density_list2, is.ggplot, TRUE)))
+	expect_true(all(vapply(density_list2, is_ggplot, TRUE)))
 })
 
 test_that("test binary categories and error messages", {

tests/testthat/test-plot-intro.R

@@ -2,5 +2,5 @@ context("plot intro")
 
 test_that("test return object", {
 	plot_obj <- plot_intro(iris)
-	expect_true(is.ggplot(plot_obj))
+	expect_true(is_ggplot(plot_obj))
 })

tests/testthat/test-plot-missing.R

@@ -2,5 +2,5 @@ context("plot missing data profile")
 
 test_that("test return object", {
   plot_obj <- plot_missing(airquality)
-  expect_true(is.ggplot(plot_obj))
+  expect_true(is_ggplot(plot_obj))
 })

tests/testthat/test-plot-scatterplot.R

@@ -11,10 +11,10 @@ test_that("test return object", {
   scatterplot_list <- plot_scatterplot(iris, by = "Species")
   expect_is(scatterplot_list, "list")
   expect_equal(names(scatterplot_list), "page_1")
-  expect_true(is.ggplot(scatterplot_list[[1]]))
+  expect_true(is_ggplot(scatterplot_list[[1]]))
 
   scatterplot_list2 <- plot_scatterplot(iris, by = "Species", nrow = 1L, ncol = 1L)
   expect_is(scatterplot_list2, "list")
   expect_equal(names(scatterplot_list2), c("page_1", "page_2", "page_3", "page_4"))
-  expect_true(all(vapply(scatterplot_list2, is.ggplot, TRUE)))
+  expect_true(all(vapply(scatterplot_list2, is_ggplot, TRUE)))
 })

tests/testthat/test-plotly.R

@@ -12,25 +12,25 @@ test_that("plotly = TRUE runs when plotly package is installed", {
   expect_silent(plot_histogram(iris, ncol = 2L, plotly = TRUE))
   out_hist <- plot_histogram(iris, ncol = 2L, plotly = TRUE)
   expect_is(out_hist, "list")
-  expect_true(all(vapply(out_hist, is.ggplot, TRUE)))
+  expect_true(all(vapply(out_hist, is_ggplot, TRUE)))
 
   expect_silent(plot_density(iris, ncol = 2L, plotly = TRUE))
   out_dens <- plot_density(iris, ncol = 2L, plotly = TRUE)
   expect_is(out_dens, "list")
-  expect_true(all(vapply(out_dens, is.ggplot, TRUE)))
+  expect_true(all(vapply(out_dens, is_ggplot, TRUE)))
 
   # Single-panel plots
   expect_silent(plot_missing(airquality, plotly = TRUE))
   out_miss <- plot_missing(airquality, plotly = TRUE)
-  expect_true(is.ggplot(out_miss))
+  expect_true(is_ggplot(out_miss))
 
   expect_silent(plot_intro(iris, plotly = TRUE))
   out_intro <- plot_intro(iris, plotly = TRUE)
-  expect_true(is.ggplot(out_intro))
+  expect_true(is_ggplot(out_intro))
 
   expect_silent(plot_correlation(iris, plotly = TRUE))
   out_cor <- plot_correlation(iris, plotly = TRUE)
-  expect_true(is.ggplot(out_cor))
+  expect_true(is_ggplot(out_cor))
 })
 
 test_that("plotly = TRUE with plot_boxplot and plot_qq when plotly is installed", {
@@ -39,12 +39,12 @@ test_that("plotly = TRUE with plot_boxplot and plot_qq when plotly is installed"
   expect_silent(plot_boxplot(iris, by = "Species", ncol = 2L, plotly = TRUE))
   out_box <- plot_boxplot(iris, by = "Species", ncol = 2L, plotly = TRUE)
   expect_is(out_box, "list")
-  expect_true(all(vapply(out_box, is.ggplot, TRUE)))
+  expect_true(all(vapply(out_box, is_ggplot, TRUE)))
 
   expect_silent(plot_qq(iris, ncol = 2L, plotly = TRUE))
   out_qq <- plot_qq(iris, ncol = 2L, plotly = TRUE)
   expect_is(out_qq, "list")
-  expect_true(all(vapply(out_qq, is.ggplot, TRUE)))
+  expect_true(all(vapply(out_qq, is_ggplot, TRUE)))
 })
 
 test_that("plotly = TRUE throws informative error when plotly is not installed", {
@@ -69,11 +69,11 @@ test_that("plotly = FALSE is default and unchanged behavior", {
   # Regression: default remains static ggplot
   out_bar <- plot_bar(iris)
   expect_is(out_bar, "list")
-  expect_true(is.ggplot(out_bar[[1]]))
+  expect_true(is_ggplot(out_bar[[1]]))
 
   out_miss <- plot_missing(airquality)
-  expect_true(is.ggplot(out_miss))
+  expect_true(is_ggplot(out_miss))
 
   out_intro <- plot_intro(iris)
-  expect_true(is.ggplot(out_intro))
+  expect_true(is_ggplot(out_intro))
 })