Skip to content

Commit 3aaff6b

Browse files
committed
resolve issue 175
1 parent d312e1d commit 3aaff6b

6 files changed

Lines changed: 465 additions & 58 deletions

File tree

NOTES.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,12 @@ These can change scc's output or behaviour for an identical invocation against
3434
- **Percentage outputs in JSON** (#720) — JSON output now includes percentage
3535
figures.
3636
- **Codeberg support** (#866376f) — Codeberg as a supported badge/target.
37+
- **External ignore files via `--ignore-file`** — supply additional gitignore-format
38+
ignore files from outside the scanned tree (repeatable, order-sensitive, anchored
39+
at the scan root; any in-tree `.gitignore`/`.ignore`/`.sccignore` takes precedence).
40+
Resolves the long-standing request for global/shared ignore support without scc
41+
shelling out to git — point it at `~/.config/git/ignore` directly, or set it once
42+
in a `.scc` file via `SCC_CONFIG_PATH`. Backed by `CustomIgnoreFiles` in gocodewalker.
3743

3844
## 🗣 Language support
3945

@@ -64,6 +70,15 @@ These can change scc's output or behaviour for an identical invocation against
6470
- Automate file generation and add CI tests (#688, #706); update to latest Go
6571
and refresh dependencies.
6672

73+
## 🗒 To discuss / follow-up
74+
75+
- **Remaining `git` subprocess shell-out**`remoteOriginName` in
76+
`processor/report.go` still runs `git config --get remote.origin.url` to derive
77+
the HTML report title. This is the only place scc shells out to the `git` binary
78+
(the rest use the go-git library or `gocodewalker.FindRepositoryRoot`). Decide
79+
whether to drop it (fall back to the path basename) or read it via go-git's config
80+
instead, so scc has no hard dependency on a `git` binary being installed.
81+
6782
---
6883

6984
_Generated from the commit history between `v3.7.0` and the 4.0.0 release._

SCC-OUTPUT-REPORT.html

Lines changed: 67 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -12,24 +12,24 @@
1212
</tr></thead>
1313
<tbody><tr>
1414
<th>Go</th>
15-
<th>65</th>
16-
<th>39405</th>
17-
<th>2953</th>
18-
<th>1963</th>
19-
<th>34489</th>
20-
<th>4336</th>
21-
<th>940656</th>
22-
<th>14313</th>
15+
<th>66</th>
16+
<th>39658</th>
17+
<th>2965</th>
18+
<th>1976</th>
19+
<th>34717</th>
20+
<th>4352</th>
21+
<th>946507</th>
22+
<th>14376</th>
2323
</tr><tr>
2424
<td>processor/constants.go</td>
2525
<td></td>
26-
<td>14687</td>
26+
<td>14855</td>
2727
<td>1</td>
2828
<td>2</td>
29-
<td>14684</td>
29+
<td>14852</td>
3030
<td>0</td>
31-
<td>235991</td>
32-
<td>2249</td>
31+
<td>239226</td>
32+
<td>2280</td>
3333
</tr><tr>
3434
<td>processor/workers_test.go</td>
3535
<td></td>
@@ -53,13 +53,13 @@
5353
</tr><tr>
5454
<td>processor/processor.go</td>
5555
<td></td>
56-
<td>1042</td>
57-
<td>197</td>
58-
<td>188</td>
59-
<td>657</td>
56+
<td>1049</td>
57+
<td>198</td>
58+
<td>192</td>
59+
<td>659</td>
6060
<td>156</td>
61-
<td>31732</td>
62-
<td>681</td>
61+
<td>32102</td>
62+
<td>687</td>
6363
</tr><tr>
6464
<td>main_test.go</td>
6565
<td></td>
@@ -83,23 +83,23 @@
8383
</tr><tr>
8484
<td>processor/workers.go</td>
8585
<td></td>
86-
<td>957</td>
86+
<td>960</td>
8787
<td>146</td>
88-
<td>95</td>
88+
<td>98</td>
8989
<td>716</td>
9090
<td>244</td>
91-
<td>28545</td>
92-
<td>543</td>
91+
<td>28788</td>
92+
<td>547</td>
9393
</tr><tr>
9494
<td>processor/report.go</td>
9595
<td></td>
96-
<td>805</td>
96+
<td>806</td>
9797
<td>79</td>
9898
<td>108</td>
99-
<td>618</td>
99+
<td>619</td>
100100
<td>112</td>
101-
<td>22568</td>
102-
<td>580</td>
101+
<td>22613</td>
102+
<td>581</td>
103103
</tr><tr>
104104
<td>processor/history.go</td>
105105
<td></td>
@@ -113,13 +113,13 @@
113113
</tr><tr>
114114
<td>config_test.go</td>
115115
<td></td>
116-
<td>785</td>
116+
<td>786</td>
117117
<td>50</td>
118118
<td>85</td>
119-
<td>650</td>
119+
<td>651</td>
120120
<td>199</td>
121-
<td>29332</td>
122-
<td>410</td>
121+
<td>29349</td>
122+
<td>411</td>
123123
</tr><tr>
124124
<td>processor/report_render.go</td>
125125
<td></td>
@@ -173,13 +173,13 @@
173173
</tr><tr>
174174
<td>config.go</td>
175175
<td></td>
176-
<td>584</td>
176+
<td>585</td>
177177
<td>24</td>
178178
<td>49</td>
179-
<td>511</td>
179+
<td>512</td>
180180
<td>40</td>
181-
<td>27743</td>
182-
<td>420</td>
181+
<td>27979</td>
182+
<td>421</td>
183183
</tr><tr>
184184
<td>processor/history_author_timeline_test.go</td>
185185
<td></td>
@@ -250,16 +250,6 @@
250250
<td>52</td>
251251
<td>10674</td>
252252
<td>281</td>
253-
</tr><tr>
254-
<td>processor/file_test.go</td>
255-
<td></td>
256-
<td>373</td>
257-
<td>70</td>
258-
<td>16</td>
259-
<td>287</td>
260-
<td>75</td>
261-
<td>8978</td>
262-
<td>178</td>
263253
</tr><tr>
264254
<td>processor/history_languages.go</td>
265255
<td></td>
@@ -270,6 +260,16 @@
270260
<td>52</td>
271261
<td>10482</td>
272262
<td>269</td>
263+
</tr><tr>
264+
<td>processor/file_test.go</td>
265+
<td></td>
266+
<td>373</td>
267+
<td>70</td>
268+
<td>16</td>
269+
<td>287</td>
270+
<td>75</td>
271+
<td>8978</td>
272+
<td>178</td>
273273
</tr><tr>
274274
<td>processor/formatters_misc.go</td>
275275
<td></td>
@@ -503,13 +503,13 @@
503503
</tr><tr>
504504
<td>processor/result.go</td>
505505
<td></td>
506-
<td>137</td>
506+
<td>138</td>
507507
<td>24</td>
508508
<td>3</td>
509-
<td>110</td>
509+
<td>111</td>
510510
<td>31</td>
511-
<td>3247</td>
512-
<td>92</td>
511+
<td>3291</td>
512+
<td>93</td>
513513
</tr><tr>
514514
<td>processor/formatters_sql.go</td>
515515
<td></td>
@@ -600,6 +600,16 @@
600600
<td>13</td>
601601
<td>2123</td>
602602
<td>62</td>
603+
</tr><tr>
604+
<td>processor/workers_issue175_test.go</td>
605+
<td></td>
606+
<td>71</td>
607+
<td>11</td>
608+
<td>6</td>
609+
<td>54</td>
610+
<td>16</td>
611+
<td>1661</td>
612+
<td>37</td>
603613
</tr><tr>
604614
<td>processor/history_ignore_test.go</td>
605615
<td></td>
@@ -673,16 +683,16 @@
673683
</tr></tbody>
674684
<tfoot><tr>
675685
<th>Total</th>
676-
<th>65</th>
677-
<th>39405</th>
678-
<th>2953</th>
679-
<th>1963</th>
680-
<th>34489</th>
681-
<th>4336</th>
682-
<th>940656</th>
683-
<th>14313</th>
686+
<th>66</th>
687+
<th>39658</th>
688+
<th>2965</th>
689+
<th>1976</th>
690+
<th>34717</th>
691+
<th>4352</th>
692+
<th>946507</th>
693+
<th>14376</th>
684694
</tr>
685695
<tr>
686-
<th colspan="9">Estimated Cost to Develop (organic) $1,112,141<br>Estimated Schedule Effort (organic) 14.32 months<br>Estimated People Required (organic) 6.90<br></th>
696+
<th colspan="9">Estimated Cost to Develop (organic) $1,119,862<br>Estimated Schedule Effort (organic) 14.36 months<br>Estimated People Required (organic) 6.93<br></th>
687697
</tr></tfoot>
688698
</table></body></html>

0 commit comments

Comments
 (0)