Skip to content

Commit 9dc2c21

Browse files
authored
Update docs to mention Python 3.12 and Ubuntu 24. (#78)
* Don't mix quotes * Ubuntu 24
1 parent 171f6e9 commit 9dc2c21

3 files changed

Lines changed: 12 additions & 7 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,13 @@ stack manage --dir ~/deployments/todo stop
6161

6262
## Install
6363

64-
**To get started quickly** on a fresh Ubuntu instance (e.g, Digital Ocean); [try this script](./scripts/quick-install-linux.sh). **WARNING:** always review scripts prior to running them so that you know what is happening on your machine.
64+
**To get started quickly** on a fresh Ubuntu 24.04 instance (e.g, Digital Ocean); [try this script](./scripts/quick-install-linux.sh). **WARNING:** always review scripts prior to running them so that you know what is happening on your machine.
6565

6666
For any other installation, follow along below and **adapt these instructions based on the specifics of your system.**
6767

6868
Ensure that the following are already installed:
6969

70-
- [Python3](https://wiki.python.org/moin/BeginnersGuide/Download): `python3 --version` >= `3.8.10` (the Python3 shipped in Ubuntu 20+ is good to go)
70+
- [Python3](https://wiki.python.org/moin/BeginnersGuide/Download): `python3 --version` >= `3.12` (the Python3 shipped in Ubuntu 24.04 is good to go)
7171
- [Docker](https://docs.docker.com/get-docker/): `docker --version` >= `20.10.21` or [podman](https://podman.io/) `podman --version` >= `3.4.4`
7272
- [jq](https://stedolan.github.io/jq/download/): `jq --version` >= `1.5`
7373
- [git](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git): `git --version` >= `2.10.3`

scripts/quick-install-linux.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,14 @@ fi
55

66
LSB_REL=`lsb_release -r | awk '{ print $2 }'`
77

8-
if [[ "$LSB_REL" != "24.04" ]] && [[ "$LSB_REL" != "22.04" ]]; then
9-
echo "This script is only meant for Ubuntu 22.04 or 24.04"
10-
echo "See https://github.com/bozemanpass/stack/blob/main/docs/CONTRIBUTING.md for manual installation on other versions."
11-
exit 1
8+
if [[ "$LSB_REL" != "24.04" ]]; then
9+
if [[ "$LSB_REL" == "22.04" ]]; then
10+
echo "This script is only supported on Ubuntu 24.04. It MAY work on 22.04, but it has not been tested."
11+
else
12+
echo "This script is only supported on Ubuntu 24.04. It is not supported on your version of Ubuntu."
13+
echo "See https://github.com/bozemanpass/stack/blob/main/docs/CONTRIBUTING.md for manual installation on other versions."
14+
exit 1
15+
fi
1216
fi
1317

1418
install_dir=~/bin

src/stack/build/build_containers.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,8 @@ def build_containers(parent_stack,
173173
containers_in_scope = [c for c in get_containers_in_scope(stack) if include_exclude_check(c.name, include, exclude)]
174174
all_containers_in_scope.extend(containers_in_scope)
175175

176-
log_info(f"Found {len(all_containers_in_scope)} containers in {len(required_stacks)} stacks: {", ".join([c.name for c in all_containers_in_scope])}", bold=True)
176+
log_info(f"Found {len(all_containers_in_scope)} containers in {len(required_stacks)} stacks: "
177+
f"{', '.join([c.name for c in all_containers_in_scope])}", bold=True)
177178

178179
for stack in required_stacks:
179180
stack = get_parsed_stack_config(stack)

0 commit comments

Comments
 (0)