Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically reboot the VM when parameter changes #1467

Open
arsensimonyanpicsart opened this issue Aug 5, 2024 · 1 comment
Open

Automatically reboot the VM when parameter changes #1467

arsensimonyanpicsart opened this issue Aug 5, 2024 · 1 comment
Labels
✨ enhancement New feature or request

Comments

@arsensimonyanpicsart
Copy link

Is your feature request related to a problem? Please describe.
I’m always frustrated when I change the Proxmox VM hardware parameters, like RAM or CPU, because the Terraform provider automatically reboots the VM to apply the changes. This can be disruptive and is not always necessary immediately.

Describe the solution you'd like
I would like an option, such as automatic_reboot (a boolean), to be added to the Proxmox Terraform provider. When set to true, the VM would automatically reboot to apply the changes. When set to false, the provider would emit a warning indicating that the VM needs to be rebooted but would not automatically perform the reboot. This gives users more control over when reboots occur.

Describe alternatives you've considered
An alternative solution could be to manually track the changes and handle the reboots outside of the Terraform provider, but this approach is error-prone and less efficient.

Additional context
Adding this option would greatly improve the flexibility and usability of the Proxmox Terraform provider, allowing users to manage VM reboots according to their specific needs and schedules. This feature would prevent unnecessary disruptions in environments where immediate reboots are not feasible.

@arsensimonyanpicsart arsensimonyanpicsart added the ✨ enhancement New feature or request label Aug 5, 2024
@waza-ari
Copy link

I'd love this, maybe even combined with a review on what changes actually do require a reboot. I've been transitioning to the new version, basically changing initialization.dns.server to initialization.dns.servers (with an array with the same DNS server as before being the only entry), which caused a reboot of the server, catching me completely off guard.

Having the option to emit the warning and reboot on your own pace (potentially in a maintenance window) would be a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants