Implement all open issues (+ Chimney 2.0.0-RC1) (#33)

Closes #3,#4,#7,#8,#9,#10,#11,#14,#18,#19,#21,#22,#23,#25,#29,#30. #28 dropped. Full suite green (108 examples, 0 failures). NoPermission->403; auth errors mapped (were 500); Chimney 2.0.0-RC1; Postgres 17.

Author: MateuszKubuszok

README.md

@@ -49,7 +49,7 @@ intended for example app:
 Building and testing requires java installed. Then
 
 ```bash
-./sbt
+sbt
 ```
 
 downloads and runs sbt shell.
@@ -61,10 +61,10 @@ just dev-bg   # starts services in background
 just dev-up   # starts services in terminal (I suggest a separate tab/window)
 ```
 
-Then it is possible to run it tests:
+Then it is possible to run integration tests:
 
 ```bash
-sbt> it:test
+sbt> fullTest
 ```
 
 ```bash

branchtalk.sbt

@@ -164,6 +164,9 @@ lazy val root = project
   .aggregate(commonInfrastructure)
   .aggregate(discussions.projectRefs *)
   .aggregate(discussionsApi.projectRefs *)
+  .aggregate(notifications.projectRefs *)
+  .aggregate(notificationsApi.projectRefs *)
+  .aggregate(notificationsImpl)
   .aggregate(users.projectRefs *)
   .aggregate(usersApi.projectRefs *)
   .aggregate(usersImpl)
@@ -390,6 +393,63 @@ val usersImpl = project
     users.jvm(Dependencies.scalaVersion)
   )
 
+// notifications
+
+val notifications = projectMatrix
+  .in(file("modules/notifications"))
+  .jvmPlatform(List(Dependencies.scalaVersion))
+  .enablePlugins(GitVersioning, GitBranchPrompt)
+  .settings(
+    name := "notifications",
+    description := "Notifications' published language"
+  )
+  .settings(settings)
+  .settings(tests)
+  .settings(
+    libraryDependencies ++= Seq(
+      Dependencies.fs2
+    ),
+    customPredef("scala.util.chaining", "cats.implicits", "neotype")
+  )
+  .dependsOn(common)
+
+val notificationsApi = projectMatrix
+  .in(file("modules/notifications-api"))
+  .jvmPlatform(List(Dependencies.scalaVersion))
+  .enablePlugins(GitVersioning, GitBranchPrompt)
+  .settings(
+    name := "notifications-api",
+    description := "Notifications' HTTP API"
+  )
+  .settings(settings)
+  .settings(tests)
+  .settings(
+    libraryDependencies ++= Seq(
+      Dependencies.kindlingsJsoniter
+    ),
+    customPredef("scala.util.chaining", "cats.implicits", "neotype")
+  )
+  .dependsOn(commonApi, notifications)
+
+val notificationsImpl = project
+  .in(file("modules/notifications-impl"))
+  .enablePlugins(GitVersioning, GitBranchPrompt)
+  .settings(
+    name := "notifications-impl",
+    description := "Notifications' Reads, Writes and Services' implementations"
+  )
+  .settings(settings)
+  .settings(integrationTests)
+  .settings(
+    customPredef("scala.util.chaining", "cats.implicits", "neotype")
+  )
+  .dependsOn(
+    common.jvm(Dependencies.scalaVersion) % s"$Compile->$Compile ; $Test->$Test",
+    commonInfrastructure % s"$Compile->$Compile ; $Test->$Test",
+    discussions.jvm(Dependencies.scalaVersion),
+    notifications.jvm(Dependencies.scalaVersion)
+  )
+
 // application
 
 val server = project
@@ -435,6 +495,9 @@ val server = project
     discussions.jvm(Dependencies.scalaVersion),
     discussionsApi.jvm(Dependencies.scalaVersion),
     discussionsImpl % s"$Test->$Test",
+    notifications.jvm(Dependencies.scalaVersion),
+    notificationsApi.jvm(Dependencies.scalaVersion),
+    notificationsImpl % s"$Test->$Test",
     users.jvm(Dependencies.scalaVersion),
     usersApi.jvm(Dependencies.scalaVersion),
     usersImpl % s"$Test->$Test"
@@ -480,7 +543,7 @@ val application = project
     },
     assembly / mainClass := Some("io.branchtalk.Main")
   )
-  .dependsOn(server, discussionsImpl, usersImpl)
+  .dependsOn(server, discussionsImpl, notificationsImpl, usersImpl)
 
 // aliases
 

docker-compose/filebeat.yml

@@ -0,0 +1,36 @@
+# Filebeat configuration — ships Docker container logs to Elasticsearch.
+# Mounted into the filebeat container by monolith-monitoring.yml.
+#
+# The application's logback already emits JSON to stdout, so Filebeat only
+# needs to pick up the container log files and forward them.
+
+filebeat.autodiscover:
+  providers:
+    - type: docker
+      hints.enabled: true
+      # Only collect logs from the branchtalk application container.
+      templates:
+        - condition:
+            contains:
+              docker.container.image: "branchtalk-server"
+          config:
+            - type: container
+              paths:
+                - "/var/lib/docker/containers/${data.docker.container.id}/*.log"
+              # The app writes JSON; Docker wraps each line in its own JSON
+              # envelope.  Decode the Docker layer, then parse the inner JSON
+              # that logback produced.
+              processors:
+                - decode_json_fields:
+                    fields: ["message"]
+                    target: "app"
+                    overwrite_keys: true
+
+output.elasticsearch:
+  hosts: ["elasticsearch:9200"]
+  indices:
+    - index: "branchtalk-logs-%{+yyyy.MM.dd}"
+
+setup.ilm.enabled: false
+setup.template.name: "branchtalk-logs"
+setup.template.pattern: "branchtalk-logs-*"

docker-compose/grafana/provisioning/datasources/prometheus.yml

@@ -0,0 +1,12 @@
+# Auto-provision Prometheus as the default Grafana data source.
+# Mounted into grafana at /etc/grafana/provisioning/datasources/ by monolith-monitoring.yml.
+
+apiVersion: 1
+
+datasources:
+  - name: Prometheus
+    type: prometheus
+    access: proxy
+    url: http://prometheus:9090
+    isDefault: true
+    editable: true

docker-compose/monolith-deps.yml

@@ -6,7 +6,7 @@ networks:
 
 services:
   postgres:
-    image: 'postgres:12-alpine'
+    image: 'postgres:17-alpine'
     restart: always
     ports:
       - '127.0.0.1:5432:5432'

docker-compose/monolith-monitoring.yml

@@ -0,0 +1,128 @@
+# Opt-in monitoring and log-aggregation stack for local development.
+#
+# Start alongside the app dependencies:
+#
+#   docker compose \
+#     -f docker-compose/monolith-deps.yml \
+#     -f docker-compose/monolith-setup.yml \
+#     -f docker-compose/monolith-monitoring.yml \
+#     up -d
+#
+# Then (optionally) the app itself:
+#
+#   docker compose -f docker-compose/monolith-app.yml up -d
+#
+# Or run the app via sbt and point Prometheus at host.docker.internal:8080.
+#
+# UIs:
+#   Prometheus  — http://localhost:9090
+#   Grafana     — http://localhost:3000  (admin / admin)
+#   Kibana      — http://localhost:5601
+#
+# Log shipping:
+#   The Filebeat sidecar reads the application container's JSON stdout logs
+#   and forwards them to Elasticsearch. If you run the app outside Docker
+#   (e.g. via sbt), pipe its output to a file and mount that file into the
+#   filebeat container, or configure a LogstashTcpSocketAppender in logback.xml
+#   (requires adding the logstash-logback-encoder dependency — see the
+#   commented-out appender in modules/app/src/main/resources/logback.xml).
+
+networks:
+  branchtalk-monolith:
+    driver: bridge
+
+services:
+
+  # ---------- Metrics ----------
+
+  prometheus:
+    image: prom/prometheus:v2.53.0
+    restart: unless-stopped
+    ports:
+      - "127.0.0.1:9090:9090"
+    volumes:
+      - ./prometheus.yml:/etc/prometheus/prometheus.yml:ro
+      - prometheus_data:/prometheus
+    command:
+      - "--config.file=/etc/prometheus/prometheus.yml"
+      - "--storage.tsdb.retention.time=7d"
+    networks:
+      - branchtalk-monolith
+
+  grafana:
+    image: grafana/grafana:11.1.0
+    restart: unless-stopped
+    ports:
+      - "127.0.0.1:3000:3000"
+    environment:
+      GF_SECURITY_ADMIN_USER: admin
+      GF_SECURITY_ADMIN_PASSWORD: admin
+    volumes:
+      - ./grafana/provisioning:/etc/grafana/provisioning:ro
+      - grafana_data:/var/lib/grafana
+    depends_on:
+      - prometheus
+    networks:
+      - branchtalk-monolith
+
+  # ---------- Log aggregation ----------
+
+  elasticsearch:
+    image: docker.elastic.co/elasticsearch/elasticsearch:8.14.1
+    restart: unless-stopped
+    ports:
+      - "127.0.0.1:9200:9200"
+    environment:
+      discovery.type: single-node
+      xpack.security.enabled: "false"          # dev-only — no auth
+      xpack.security.http.ssl.enabled: "false"
+      ES_JAVA_OPTS: "-Xms512m -Xmx512m"
+    volumes:
+      - es_data:/usr/share/elasticsearch/data
+    healthcheck:
+      test: ["CMD-SHELL", "curl -sf http://localhost:9200/_cluster/health || exit 1"]
+      interval: 10s
+      timeout: 10s
+      retries: 10
+    networks:
+      - branchtalk-monolith
+
+  kibana:
+    image: docker.elastic.co/kibana/kibana:8.14.1
+    restart: unless-stopped
+    ports:
+      - "127.0.0.1:5601:5601"
+    environment:
+      ELASTICSEARCH_HOSTS: http://elasticsearch:9200
+    depends_on:
+      elasticsearch:
+        condition: service_healthy
+    networks:
+      - branchtalk-monolith
+
+  # Filebeat reads the application container's stdout (JSON) and ships to ES.
+  # If the application container is not running, Filebeat idles harmlessly.
+  filebeat:
+    image: docker.elastic.co/beats/filebeat:8.14.1
+    restart: unless-stopped
+    user: root                                  # needs access to docker socket / log files
+    volumes:
+      - ./filebeat.yml:/usr/share/filebeat/filebeat.yml:ro
+      - /var/lib/docker/containers:/var/lib/docker/containers:ro
+      - /var/run/docker.sock:/var/run/docker.sock:ro
+      - filebeat_data:/usr/share/filebeat/data
+    depends_on:
+      elasticsearch:
+        condition: service_healthy
+    networks:
+      - branchtalk-monolith
+
+volumes:
+  prometheus_data:
+    driver: local
+  grafana_data:
+    driver: local
+  es_data:
+    driver: local
+  filebeat_data:
+    driver: local

docker-compose/monolith-setup.yml

@@ -6,14 +6,17 @@ networks:
 
 services:
   postgres-setup:
-    image: 'postgres:12-alpine'
+    image: 'postgres:17-alpine'
     command: >
       sh -c "(psql --host postgres --username postgres --command=\"CREATE DATABASE users\" || true) &&
              (psql --host postgres --username postgres --command=\"CREATE USER users WITH PASSWORD 'password'\" users || true) &&
              (psql --host postgres --username postgres --command=\"CREATE SCHEMA users AUTHORIZATION users\" users || true) &&
              (psql --host postgres --username postgres --command=\"CREATE DATABASE discussions\" || true) &&
              (psql --host postgres --username postgres --command=\"CREATE USER discussions WITH PASSWORD 'password'\" discussions || true) &&
-             (psql --host postgres --username postgres --command=\"CREATE SCHEMA discussions AUTHORIZATION discussions\" discussions || true)"
+             (psql --host postgres --username postgres --command=\"CREATE SCHEMA discussions AUTHORIZATION discussions\" discussions || true) &&
+             (psql --host postgres --username postgres --command=\"CREATE DATABASE notifications\" || true) &&
+             (psql --host postgres --username postgres --command=\"CREATE USER notifications WITH PASSWORD 'password'\" notifications || true) &&
+             (psql --host postgres --username postgres --command=\"CREATE SCHEMA notifications AUTHORIZATION notifications\" notifications || true)"
     environment:
       PGPASSWORD: password # for psql
     depends_on:
@@ -28,7 +31,9 @@ services:
       sh -c '/opt/kafka/bin/kafka-topics.sh --create --if-not-exists --bootstrap-server kafka:9094 --partitions 1 --replication-factor 1 --topic users &&
              /opt/kafka/bin/kafka-topics.sh --create --if-not-exists --bootstrap-server kafka:9094 --partitions 1 --replication-factor 1 --topic users-internal &&
              /opt/kafka/bin/kafka-topics.sh --create --if-not-exists --bootstrap-server kafka:9094 --partitions 1 --replication-factor 1 --topic discussions &&
-             /opt/kafka/bin/kafka-topics.sh --create --if-not-exists --bootstrap-server kafka:9094 --partitions 1 --replication-factor 1 --topic discussions-internal'
+             /opt/kafka/bin/kafka-topics.sh --create --if-not-exists --bootstrap-server kafka:9094 --partitions 1 --replication-factor 1 --topic discussions-internal &&
+             /opt/kafka/bin/kafka-topics.sh --create --if-not-exists --bootstrap-server kafka:9094 --partitions 1 --replication-factor 1 --topic notifications &&
+             /opt/kafka/bin/kafka-topics.sh --create --if-not-exists --bootstrap-server kafka:9094 --partitions 1 --replication-factor 1 --topic notifications-internal'
     depends_on:
       kafka:
         condition: service_healthy

docker-compose/prometheus.yml

@@ -0,0 +1,15 @@
+# Prometheus scrape configuration for branchtalk monitoring stack.
+# Mounted into the prometheus container by monolith-monitoring.yml.
+
+global:
+  scrape_interval: 15s
+  evaluation_interval: 15s
+
+scrape_configs:
+  - job_name: "branchtalk"
+    # The application exposes GET /metrics (Prometheus text format 0.0.4).
+    # When running inside Docker, "application" resolves via the compose network;
+    # when scraping a host-local app, use host.docker.internal:8080 instead.
+    static_configs:
+      - targets: ["application:8080"]
+    metrics_path: "/metrics"