Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run npm run build to generate resources.json during packaging time #971

Open
ShivanKaul opened this issue Aug 28, 2024 · 2 comments
Open
Assignees

Comments

@ShivanKaul
Copy link
Collaborator

We currently consume resources.json (https://github.com/brave/adblock-resources/blob/master/dist/resources.json) in crx-packager. This requires remembering to run npm run build when adding/editing a resource under resources/ like in brave/adblock-resources#207

We should just run npm run build in crx-packager on the raw resources.

@ryanbr
Copy link

ryanbr commented Aug 28, 2024

My npm build in LTS is 8, which isn't supported :(

@antonok-edm
Copy link
Collaborator

@ryanbr what @ShivanKaul is saying is we can run it on the servers, so you won't need any extra steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants