Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to disable the automatic logging added by this package for "Job Processing" and "Job Processed" ? #146

Open
vesper8 opened this issue Dec 29, 2023 · 10 comments

Comments

@vesper8
Copy link

vesper8 commented Dec 29, 2023

I noticed ever since I added this package that my log file becomes filled with Job Processing and Job Processed for all of my queued jobs, including whenever I broadcast an event. I was surprised to not find an entry in the config file to disable this behaviour? Am I missing something?

@mnapoli
Copy link
Member

mnapoli commented Dec 29, 2023

Hi! I don't think you're missing anything, this could be great to have an option, like for #143

@tillkruss
Copy link
Member

Should we maybe add a bref.log_level option so it's configureable and documented?

@mnapoli
Copy link
Member

mnapoli commented Dec 29, 2023

That sounds like a good idea!

@tillkruss
Copy link
Member

@vesper8 Feel like submitting a PR?

@vesper8
Copy link
Author

vesper8 commented Jan 3, 2024

Sure : )

Here you go #147

Please don't ask me to write tests for this :-/

@tillkruss
Copy link
Member

Thanks @vesper8, I think we need to talk this out internally, but we'll have a solution in a few days 👍

@camilord
Copy link

camilord commented Sep 2, 2024

is the config to disable the logging implemented yet?

i have the same issue. the log info is just massive in cloudwatch and unmanageable.

@MightySepp666
Copy link

@tillkruss the massive amount of logging is increasing our CloudWatch logs costs significantly (we have hundreds of millions of requests and job executions per month). It does not really provide any meaningful information but pollutes the logs. Please allow this to be switched off (a simple switch option is sufficient for me).

@mnapoli
Copy link
Member

mnapoli commented Sep 11, 2024

@MightySepp666 can you please send a PR (see #147 for a base).

@MightySepp666
Copy link

Hi @mnapoli, thank's for the great work you're doing here. I appreciate it and will try to put this on our board.

I've read through the discussion in the mentioned PR, but it seemed to me that no consensus had yet been found on how to implement this (sorry if I missed that part). So could you maybe point me to the way, how you would like this to be implemented? I personally feel, like this logging should rather be of type "debug", but I'm ok with making the level configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants