Skip to content

instanceof Date doesn't always catch all Date objects #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Srayman opened this issue Nov 14, 2022 · 0 comments · May be fixed by #2862
Open

instanceof Date doesn't always catch all Date objects #2860

Srayman opened this issue Nov 14, 2022 · 0 comments · May be fixed by #2862
Labels
bug

Comments

@Srayman
Copy link

Srayman commented Nov 14, 2022

We have a Rust library creating Date objects so they are not an instance of Date but are a valid Date object.

Using util.types.isDate validates that the object is a Date and is what we're using in our local project.

We ran into an issue when saving a TIMESTAMP with this Date object where the timezone was not being handled correctly.

What's the best way to handle this scenario?
@charmander charmander added the bug label Nov 15, 2022
@Srayman Srayman linked a pull request Nov 17, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change instanceof(Date) to util.types.isDate(Date) Srayman/node-postgres
2 participants
@charmander @Srayman