Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hitting ESC should work inside of menu, change <h1> to <h2> #20

Open
jaredcwhite opened this issue Feb 28, 2023 · 0 comments
Open

Hitting ESC should work inside of menu, change <h1> to <h2> #20

jaredcwhite opened this issue Feb 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jaredcwhite
Copy link
Member

Testing with macOS Safari + VoiceOver and keyboard navigation, seems pretty decent to get to the list of search results, but then you can't hit ESC to exit out of the results, so you sort of get stuck in there.

Also, hearing "heading level 1" for each item feels strange. Probably makes more sense as <h2> tags even though you're inside of shadow DOM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaredcwhite