added unbreaking for legacy

Author: broken1arrow

Item Creator/src/main/java/org/broken/arrow/library/itemcreator/CreateItemStack.java

@@ -9,24 +9,17 @@
 import org.broken.arrow.library.itemcreator.meta.enhancement.EnhancementWrapper;
 import org.broken.arrow.library.itemcreator.meta.potion.PotionTypeWrapper;
 import org.broken.arrow.library.itemcreator.utility.ConvertToItemStack;
-import org.broken.arrow.library.itemcreator.utility.Tuple;
 import org.broken.arrow.library.itemcreator.utility.builders.ItemBuilder;
 import org.broken.arrow.library.itemcreator.utility.nbt.NBTDataWriter;
 import org.broken.arrow.library.logging.Logging;
 import org.broken.arrow.library.logging.Validate;
-import org.broken.arrow.library.nbt.RegisterNbtAPI;
-import org.bukkit.DyeColor;
-import org.bukkit.FireworkEffect;
 import org.bukkit.Material;
-import org.bukkit.NamespacedKey;
-import org.bukkit.block.banner.Pattern;
 import org.bukkit.enchantments.Enchantment;
 import org.bukkit.inventory.ItemFlag;
 import org.bukkit.inventory.ItemStack;
 import org.bukkit.inventory.meta.Damageable;
 import org.bukkit.inventory.meta.ItemMeta;
 import org.bukkit.inventory.meta.PotionMeta;
-import org.bukkit.potion.PotionEffect;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
@@ -550,8 +543,9 @@ private ItemStack getItemStack(@Nonnull ItemStack itemStack) {
         if (!isAir(itemStack.getType())) {
             itemStack = setNbt(itemStack);
 
-            final ItemMeta itemMeta = itemStack.getItemMeta();
-            setMetadata(itemStack, itemMeta);
+            ItemMeta itemMeta = itemStack.getItemMeta();
+            itemMeta = setMetadata(itemStack, itemMeta);
+
             if (this.metaHandler != null)
                 this.metaHandler.applyMeta(itemStack, itemMeta);
             itemStack.setItemMeta(itemMeta);
@@ -569,7 +563,7 @@ private ItemStack setNbt(ItemStack itemStack) {
         return itemStack;
     }
 
-    private void setMetadata(ItemStack itemStack, final ItemMeta itemMeta) {
+    private ItemMeta setMetadata(ItemStack itemStack, final ItemMeta itemMeta) {
         if (itemMeta != null) {
             if (this.displayName != null) {
                 itemMeta.setDisplayName(translateColors(this.displayName));
@@ -579,6 +573,7 @@ private void setMetadata(ItemStack itemStack, final ItemMeta itemMeta) {
             }
             addItemMeta(itemStack, itemMeta);
         }
+        return setUnbreakableMeta(itemMeta);
     }
 
 
@@ -611,10 +606,8 @@ private ItemStack checkTypeOfItem(final Object object) {
 
     private void addItemMeta(@Nonnull final ItemStack itemStack, @Nonnull final ItemMeta itemMeta) {
         this.setDamageMeta(itemStack, itemMeta);
-        if (this.serverVersion > 10.0F)
-            setUnbreakableMeta(itemMeta);
-        this.addCustomModelData(itemMeta);
 
+        this.addCustomModelData(itemMeta);
         if (isShowEnchantments() || !this.getItemFlags().isEmpty() || this.isGlow())
             hideEnchantments(itemMeta);
     }
@@ -651,9 +644,8 @@ private void hideEnchantments(final ItemMeta itemMeta) {
         }
     }
 
-
-    private void setUnbreakableMeta(final ItemMeta itemMeta) {
-        itemMeta.setUnbreakable(isUnbreakable());
+    private ItemMeta setUnbreakableMeta(final ItemMeta itemMeta) {
+        return ItemCreator.applyUnbreakable(itemMeta,isUnbreakable());
     }
 
     private void addCustomModelData(final ItemMeta itemMeta) {

Item Creator/src/main/java/org/broken/arrow/library/itemcreator/ItemCreator.java

@@ -72,7 +72,6 @@ public ItemCreator(final Plugin pluginInstance, boolean turnOffLogger) {
 
         this.convertItems = new ConvertToItemStack(serverVersion.getServerVersion());
 
-        Bukkit.getScheduler().runTaskLater(pluginInstance, () -> UnbreakableUtil.isUnbreakable(null), 1L);
         try {
             TextTranslator.getInstance();
         } catch (NoClassDefFoundError ignore) {

Item Creator/src/main/java/org/broken/arrow/library/itemcreator/utility/compound/LegacyNBT.java

@@ -23,7 +23,8 @@
 public class LegacyNBT {
     private static final Logging logger = new Logging(NbtData.class);
 
-    private LegacyNBT() {}
+    private LegacyNBT() {
+    }
 
     /**
      * Creates a new {@link NmsItemSession} for the given Bukkit {@link ItemStack}.
@@ -106,7 +107,7 @@ public static class NmsItemSession {
 
                 Class<?> craftItemStack = Class.forName(craftPath + ".inventory.CraftItemStack");
                 Class<?> nmsItemStack = Class.forName(nmsPath + ".ItemStack");
-                Class<?> nbtTagCompound = Class.forName(nmsPath + ".NBTTagCompound");
+                Class<?> nbtTagCompound = Class.forName(getNbtTagPath());
 
                 asNMSCopyItem = craftItemStack.getMethod("asNMSCopy", ItemStack.class);
                 bukkitCopy = craftItemStack.getMethod("asBukkitCopy", nmsItemStack);
@@ -346,10 +347,10 @@ public boolean getBoolean(@Nonnull String key) {
             return false;
         }
 
-        private static String getNbtTagPath() {
-            return getNmsPath() + ".NBTTagCompound";
-        }
+    }
 
+    private static String getNbtTagPath() {
+        return getNmsPath() + ".NBTTagCompound";
     }
 
     private static String getNmsPath() {