Skip to content

Commit 5ad2d24

Browse files
committed
clean up the logic and fix typos
When you get the pixels it will also have the synchronized tag
1 parent 5872179 commit 5ad2d24

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

Item Creator/src/main/java/org/broken/arrow/library/itemcreator/meta/map/MapRendererData.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.broken.arrow.library.itemcreator.meta.map;
22

3+
import org.broken.arrow.library.itemcreator.meta.map.builder.RenderConfigurator;
34
import org.broken.arrow.library.itemcreator.meta.map.color.parser.AmpersandHexColorParser;
45
import org.broken.arrow.library.itemcreator.meta.map.color.parser.ColorParser;
56
import org.broken.arrow.library.itemcreator.meta.map.cursor.MapCursorAdapter;
@@ -23,6 +24,7 @@
2324
import java.util.List;
2425
import java.util.Map;
2526
import java.util.Objects;
27+
import java.util.function.Consumer;
2628
import java.util.stream.Collectors;
2729

2830
/**
@@ -202,7 +204,7 @@ public void addText(final int layer, @Nonnull final TextOverlay textOverlay) {
202204
* and inserts it into the pixel list. Only basic scaling is performed at this
203205
* stage. Advanced preprocessing—such as color balancing, palette matching,
204206
* or pixel extraction—is applied only when using {@link MapRendererDataCache}
205-
* together with {@link BuildMapView#loadCachedLayer(int, MapRendererDataCache)}.
207+
* together with {@link RenderConfigurator#withCachedLayer(int, int, MapRendererDataCache)} .
206208
* </p>
207209
*
208210
* <p>When using the cache, all images are preprocessed asynchronously and then

Item Creator/src/main/java/org/broken/arrow/library/itemcreator/meta/map/builder/RenderConfigurator.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ public RenderConfigurator(@Nonnull final MapRendererData renderer, @Nonnull fina
4141
* @param config a consumer that modifies the {@link MapRendererData} instance
4242
* @return a step object allowing cached layer loading or builder configuration
4343
*/
44-
public RendererStepAfter withRenderer(@Nonnull final Consumer<MapRendererData> config) {
44+
public RenderStepAfter withRenderer(@Nonnull final Consumer<MapRendererData> config) {
4545
config.accept(this.renderer);
46-
return new RendererStepAfter(this.renderer, this.mapRendererBuilder);
46+
return new RenderStepAfter(this.renderer, this.mapRendererBuilder);
4747
}
4848

4949
/**
@@ -57,8 +57,8 @@ public RendererStepAfter withRenderer(@Nonnull final Consumer<MapRendererData> c
5757
* @param cache the cache providing pixel data
5858
* @return a step object allowing renderer or builder configuration
5959
*/
60-
public RendererStepAfterCache withCachedLayer(final int layer, final int cacheId, @Nonnull final MapRendererDataCache cache) {
60+
public RenderStepAfterCache withCachedLayer(final int layer, final int cacheId, @Nonnull final MapRendererDataCache cache) {
6161
cache.setLayerToRender(layer,cacheId ,this.renderer);
62-
return new RendererStepAfterCache(renderer, mapRendererBuilder);
62+
return new RenderStepAfterCache(renderer, mapRendererBuilder);
6363
}
6464
}

Item Creator/src/main/java/org/broken/arrow/library/itemcreator/meta/map/builder/RendererStepAfter.java renamed to Item Creator/src/main/java/org/broken/arrow/library/itemcreator/meta/map/builder/RenderStepAfter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
*
1313
* <p>Allows optional loading of cached layers or builder configuration.</p>
1414
*/
15-
public class RendererStepAfter extends FinalRenderStep {
15+
public class RenderStepAfter extends FinalRenderStep {
1616

1717
private final MapRendererData renderer;
1818

@@ -22,7 +22,7 @@ public class RendererStepAfter extends FinalRenderStep {
2222
* @param renderer the renderer instance configured in the previous step
2323
* @param mapRendererBuilder the builder instance used for automatic layer assignment
2424
*/
25-
public RendererStepAfter(@Nonnull final MapRendererData renderer, @Nonnull final MapRendererBuilder mapRendererBuilder) {
25+
public RenderStepAfter(@Nonnull final MapRendererData renderer, @Nonnull final MapRendererBuilder mapRendererBuilder) {
2626
super(mapRendererBuilder);
2727
this.renderer = renderer;
2828
}

Item Creator/src/main/java/org/broken/arrow/library/itemcreator/meta/map/builder/RendererStepAfterCache.java renamed to Item Creator/src/main/java/org/broken/arrow/library/itemcreator/meta/map/builder/RenderStepAfterCache.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
*
1212
* <p>Allows optional renderer configuration or builder configuration.</p>
1313
*/
14-
public class RendererStepAfterCache extends FinalRenderStep {
14+
public class RenderStepAfterCache extends FinalRenderStep {
1515
private final MapRendererData renderer;
1616

1717
/**
@@ -20,7 +20,7 @@ public class RendererStepAfterCache extends FinalRenderStep {
2020
* @param renderer the renderer instance receiving cached layers
2121
* @param mapRendererBuilder the builder instance used for automatic layer assignment
2222
*/
23-
public RendererStepAfterCache(@Nonnull final MapRendererData renderer, @Nonnull final MapRendererBuilder mapRendererBuilder) {
23+
public RenderStepAfterCache(@Nonnull final MapRendererData renderer, @Nonnull final MapRendererBuilder mapRendererBuilder) {
2424
super(mapRendererBuilder);
2525
this.renderer = renderer;
2626
}

Item Creator/src/main/java/org/broken/arrow/library/itemcreator/meta/map/cache/MapRendererDataCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ public synchronized void appendPixels(@Nonnull final List<MapPixel> extraPixels)
409409
*
410410
* @return the list of pixels
411411
*/
412-
public List<MapPixel> getPixels() {
412+
public synchronized List<MapPixel> getPixels() {
413413
return pixels;
414414
}
415415
}

0 commit comments

Comments
 (0)