Any tips to fix circular imports?

[matmair]

Hi and thank you for this interesting library!
I tried it on a project with a reasonably long migration history inventree/InvenTree#9277 and it seems that the results are raising a bunch of circular imports. Any tips on handling the tool to reduce those?

[browniebroke]

Oh that's interesting. The new migrations are created by calling Django's makemigrations so I don't know too much about its internals for resolving these. I assume that might be because 2 of yours apps are too coupled together... You may want to play with REMAKE_MIGRATIONS_FIRST_APPS and REMAKE_MIGRATIONS_LAST_APPS to try to nudge Django in creating migrations there first or last:

https://django-remake-migrations.readthedocs.io/en/latest/configuration.html

[matmair]

that is an interesting idea - thank you!
Would you be open to a PR that adds detection if a circular migration set was created?

[browniebroke]

Sure, but such feature would have to have test coverage. If you don't know how to start with that, a first step would be to create a more minimal reproduction outside of your project, e.g. something with a 2 or 3 models across 2 apps with the problem.

However, as this package delegates the logic to Django's makemigrations command, the fix might well be in Django itself...