Comments

Author: sidprasad

src/web/editor.html

@@ -31,8 +31,7 @@
   <script>var APP_LOG_URL = "{{{ LOG_URL }}}";</script>
   <script src="{{ &BASE_URL }}/js/localSettings.js"></script>
 
-  <!-- [TODO] These will have to be updated to be local. -->
-
+  <!-- CnD files. These could be conditionally imported or bundled locally if needed. -->
   <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/browser/cnd-core-complete.global.js"></script>  
   <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/components/react-component-integration.global.js"></script>
   <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/dist/components/react-component-integration.css" /> 

src/web/js/cpo-main.js

@@ -443,12 +443,9 @@
       };
       window.replWidget = CPO.replWidget = replWidget;
 
-      // SP : Exposing repl for use. Is this a great idea? Probably not.
+      // Exposing this for dom-render.js to use for input.
       window.__internalRepl = repl;
-      // SP: Should this be RE-RUN every time?
-      // Evaluating an expression failed. It was expected to evaluate to a "Pyret Value". It evaluated to the non-"Pyret Value" value: "non-Pyret value; see the console for more details"
-      //window.__currentModules = gf(repl, "current-modules").app();
-
+    
       /*
       $("#runDropdown").click(function() {
         $("#run-dropdown-content").toggle();

src/web/js/output-ui.js

@@ -1701,13 +1701,16 @@
           }
           container.append($("<span>").text(")"));
         } else if (runtime.ffi.isVSConstrRender(val)) {
-          // TODO:
-          // - Fallthrough for isInRendererContext being false to just use vsconstr
-          // - Safely calling CPO here: are we on a CPO stack? (YES: we are within a runThunk that's running toReprJS)
-          // - Make a JS rendered that's nice and expose some JS combinators
 
 
-          // vs-alternatives(skels :: RawArray<ValueSkeleton>)
+          // We know we are on the CPO stack here (within a runThink that's running toReprJS).
+          // This means we can safely call CPO here.
+
+
+          // A good improvement here would be to build some kind of fallthrough mechanism when 
+          // isInRendererContext being false to just use vsconstr
+
+
 
           var items = runtime.ffi.toArray(runtime.getField(val, "args"));
           var currentContainer;