Skip to content

Commit d6aa106

Browse files
guillaume-gricourttduigou
authored andcommitted
fix(knime): mv logger arg to another function
1 parent be2de7c commit d6aa106

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

retropath2_wrapper/knime.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,8 @@ def install(self, path: str, logger: Logger = getLogger(__name__)) -> bool:
251251
args += ["-bundlepool", p2_dir]
252252
args += ["-destination", os.path.abspath(os.path.join(self.kinstall, dirs_only_after.pop()))]
253253
args += ["-i", ",".join(Knime.PLUGINS)]
254+
logger.info("Command line to install Knime plugins")
255+
logger.info(" ".join(args))
254256
CPE = subprocess.run(args)
255257
logger.debug(CPE)
256258

@@ -364,12 +366,14 @@ def install_local(args, logger: Logger = getLogger(__name__)):
364366
tempdir = tempfile.mkdtemp()
365367
os.makedirs(path_knime, exist_ok=True)
366368
try:
369+
logger.info(f"Unzip: {path_zenodo}")
367370
unzip(
368371
file=path_zenodo,
369372
dir=tempdir,
370373
)
371-
knime = Knime(kinstall=path_knime, logger=logger)
372-
knime.install(path=tempdir)
374+
knime = Knime(kinstall=path_knime)
375+
logger.info(f"Install to: {path_knime}")
376+
knime.install(path=tempdir, logger=logger)
373377
except Exception as e:
374378
raise RuntimeError(e)
375379
finally:

0 commit comments

Comments
 (0)