feat: implement async methods for capacity categories and add comprehensive tests

Author: btoron

ofsc/async_client/metadata.py

@@ -451,10 +451,70 @@ async def get_capacity_area(self, label: str) -> CapacityArea:
     async def get_capacity_categories(
         self, offset: int = 0, limit: int = 100
     ) -> CapacityCategoryListResponse:
-        raise NotImplementedError("Async method not yet implemented")
+        """Get all capacity categories with pagination.
+
+        Args:
+            offset: Starting record number (default 0)
+            limit: Maximum number to return (default 100)
+
+        Returns:
+            CapacityCategoryListResponse: List of capacity categories
+
+        Raises:
+            OFSCAuthenticationError: If authentication fails (401)
+            OFSCAuthorizationError: If authorization fails (403)
+            OFSCApiError: For other API errors
+            OFSCNetworkError: For network/transport errors
+        """
+        url = urljoin(self.baseUrl, "/rest/ofscMetadata/v1/capacityCategories")
+        params = {"offset": offset, "limit": limit}
+
+        try:
+            response = await self._client.get(url, headers=self.headers, params=params)
+            response.raise_for_status()
+            data = response.json()
+            if "links" in data and not hasattr(CapacityCategoryListResponse, "links"):
+                del data["links"]
+            return CapacityCategoryListResponse.model_validate(data)
+        except httpx.HTTPStatusError as e:
+            self._handle_http_error(e, "Failed to get capacity categories")
+            raise
+        except httpx.TransportError as e:
+            raise OFSCNetworkError(f"Network error: {str(e)}") from e
 
     async def get_capacity_category(self, label: str) -> CapacityCategory:
-        raise NotImplementedError("Async method not yet implemented")
+        """Get a single capacity category by label.
+
+        Args:
+            label: The capacity category label to retrieve
+
+        Returns:
+            CapacityCategory: The capacity category details
+
+        Raises:
+            OFSCNotFoundError: If capacity category not found (404)
+            OFSCAuthenticationError: If authentication fails (401)
+            OFSCAuthorizationError: If authorization fails (403)
+            OFSCApiError: For other API errors
+            OFSCNetworkError: For network/transport errors
+        """
+        encoded_label = quote_plus(label)
+        url = urljoin(
+            self.baseUrl, f"/rest/ofscMetadata/v1/capacityCategories/{encoded_label}"
+        )
+
+        try:
+            response = await self._client.get(url, headers=self.headers)
+            response.raise_for_status()
+            data = response.json()
+            if "links" in data and not hasattr(CapacityCategory, "links"):
+                del data["links"]
+            return CapacityCategory.model_validate(data)
+        except httpx.HTTPStatusError as e:
+            self._handle_http_error(e, f"Failed to get capacity category '{label}'")
+            raise
+        except httpx.TransportError as e:
+            raise OFSCNetworkError(f"Network error: {str(e)}") from e
 
     # endregion
 

ofsc/models.py

@@ -457,39 +457,6 @@ class BulkUpdateResponse(BaseModel):
     results: Optional[List[BulkUpdateResult]] = None
 
 
-# region 202403 Capacity Categories
-class Item(BaseModel):
-    label: str
-    name: Optional[str] = None
-
-
-class ItemList(RootModel[List[Item]]):
-    def __iter__(self):
-        return iter(self.root)
-
-    def __getitem__(self, item):
-        return self.root[item]
-
-
-class CapacityCategory(BaseModel):
-    label: str
-    name: str
-    timeSlots: Optional[ItemList] = None
-    translations: Annotated[Optional[TranslationList], Field(alias="translations")] = (
-        None
-    )
-    workSkillGroups: Optional[ItemList] = None
-    workSkills: Optional[ItemList] = None
-    active: bool
-    model_config = ConfigDict(extra="allow")
-
-
-class CapacityCategoryListResponse(OFSResponseList[CapacityCategory]):
-    pass
-
-
-#  endregion
-
 # region 202404 Metadata - Time Slots
 # endregion
 # region 202404 Metadata - Workzones
@@ -1423,6 +1390,38 @@ class CapacityAreaListResponse(OFSResponseList[CapacityArea]):
 # endregion Metadata / Capacity Areas
 
 # region Metadata / Capacity Categories
+
+
+class Item(BaseModel):
+    label: str
+    name: Optional[str] = None
+
+
+class ItemList(RootModel[list[Item]]):
+    def __iter__(self):  # type: ignore[override]
+        return iter(self.root)
+
+    def __getitem__(self, item):
+        return self.root[item]
+
+
+class CapacityCategory(BaseModel):
+    label: str
+    name: str
+    timeSlots: Optional[ItemList] = None
+    translations: Annotated[Optional[TranslationList], Field(alias="translations")] = (
+        None
+    )
+    workSkillGroups: Optional[ItemList] = None
+    workSkills: Optional[ItemList] = None
+    active: bool
+    model_config = ConfigDict(extra="allow")
+
+
+class CapacityCategoryListResponse(OFSResponseList[CapacityCategory]):
+    pass
+
+
 # endregion Metadata / Capacity Categories
 
 # region Metadata / Forms

scripts/capture_api_responses.py

@@ -278,6 +278,35 @@
             "metadata": {"capacity_area_label": "NONEXISTENT_AREA_12345"},
         },
     ],
+    "capacity_categories": [
+        {
+            "name": "get_capacity_categories_200_success",
+            "description": "Get all capacity categories with pagination",
+            "method": "GET",
+            "path": "/rest/ofscMetadata/v1/capacityCategories",
+            "params": {"offset": 0, "limit": 100},
+            "body": None,
+            "metadata": {},
+        },
+        {
+            "name": "get_capacity_category_200_success",
+            "description": "Get a single capacity category by label",
+            "method": "GET",
+            "path": "/rest/ofscMetadata/v1/capacityCategories/EST",
+            "params": None,
+            "body": None,
+            "metadata": {"capacity_category_label": "EST"},
+        },
+        {
+            "name": "get_capacity_category_404_not_found",
+            "description": "Get a non-existent capacity category",
+            "method": "GET",
+            "path": "/rest/ofscMetadata/v1/capacityCategories/NONEXISTENT_CATEGORY_12345",
+            "params": None,
+            "body": None,
+            "metadata": {"capacity_category_label": "NONEXISTENT_CATEGORY_12345"},
+        },
+    ],
     "non_working_reasons": [
         {
             "name": "get_non_working_reasons_200_success",