Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd-trace dependency #4

Open
colinscape opened this issue Nov 25, 2019 · 3 comments
Open

dd-trace dependency #4

colinscape opened this issue Nov 25, 2019 · 3 comments
Assignees

Comments

@colinscape
Copy link

I see the dd-trace dependency is only in the require-dev section of composer.json. However, given the implementation, it looks like dd-trace is expected to be present. Should we move this into the full require section instead?

@erickhun
Copy link
Collaborator

ah good one @colinscape !

I need to double check on that by using the lib in a project, but I remembered with buffer-web, having the php dd-trace in composer + dd-trace binary package (dpkg) created some namespace conflicts. I think this is because the php library is already present in the binary package. (it's also why I had to remove it from https://github.com/bufferapp/buffer-web/pull/16716 )

If that's the case we would certainly make a check, perhaps by detecting if the Datadog\DDTrace namespace exist if anyone use the Bufflog php library

@colinscape
Copy link
Author

Ah, interesting! Yup, that feels like a good one to check out how things behave in practice! 👍

@erickhun
Copy link
Collaborator

For that one, I think we will need a way to detect if the dd tracer extension has been properly setup in the docker image 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants