You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see the dd-trace dependency is only in the require-dev section of composer.json. However, given the implementation, it looks like dd-trace is expected to be present. Should we move this into the full require section instead?
The text was updated successfully, but these errors were encountered:
I need to double check on that by using the lib in a project, but I remembered with buffer-web, having the php dd-trace in composer + dd-trace binary package (dpkg) created some namespace conflicts. I think this is because the php library is already present in the binary package. (it's also why I had to remove it from https://github.com/bufferapp/buffer-web/pull/16716 )
If that's the case we would certainly make a check, perhaps by detecting if the Datadog\DDTrace namespace exist if anyone use the Bufflog php library
I see the dd-trace dependency is only in the
require-dev
section of composer.json. However, given the implementation, it looks like dd-trace is expected to be present. Should we move this into the fullrequire
section instead?The text was updated successfully, but these errors were encountered: