add fallback path for androidmanifest.xml android proguard #249
+53
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
reviewed
Dec 4, 2025
pkg/android/find-android-manifest.go
Outdated
| // | ||
| // Returns: | ||
| // - string: The first existing manifest path, or an empty string if none are found. | ||
| func FindAndroidManifest(paths []string) string { |
Contributor
There was a problem hiding this comment.
Could this function rather take the common merged manifest directory and variant name and look in the two known locations?
<merged_manifest_path>/<variant>/AndroidManifest.xml
<merged_manifest_path>/<variant>/process<variant>Manfiest/AndroidManifest.xml
Contributor
Author
There was a problem hiding this comment.
I've updated the function to accept the merged_manifest_path and variant. It then builds and checks the paths within the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Update how we check for the AndroidManifest.xml file for the
upload android-proguardcommand by checking a fallback path if it is not present in the default location.Testing
Covered by CI