Merge pull request #192 from bugsnag/release/v4.1.1

Release v4.1.1

Author: SB-gulshans

CHANGELOG.md

@@ -1,6 +1,13 @@
 Changelog
 =========
 
+## 4.1.1 (2026-04-21)
+
+### Bug fixes
+* Amend secondary instance URL to bugsnag.smartbear.com 
+  | [richardelms](https://github.com/richardelms)
+  | [#186](https://github.com/bugsnag/bugsnag-dotnet/pull/186)
+
 ## 4.1.0 (2025-07-17)
 
 ### Enhancements

CONTRIBUTING.md

@@ -2,10 +2,12 @@
 
 ## Development Dependencies
 
-- Windows 10 pro
+- Windows 10 or later
 - Docker for Windows
-- Visual Studio 2017
-- [.NET framework 3.5](https://docs.microsoft.com/en-us/dotnet/framework/install/dotnet-35-windows-10)
+- Visual Studio 2022 or later
+- .NET SDK 6.0+
+- .NET SDK 8.0 (for running tests)
+- .NET Framework 4.6.2 targeting pack
 
 ## Running the build script
 
@@ -51,23 +53,37 @@ See the [README](examples)
 If you're a member of the core team, follow these instructions for releasing
 bugsnag-dotnet.
 
-### First-time setup
+### Versioning
 
-### Every time
+This project follows [semantic versioning](http://semver.org):
 
-* Compile new features, enhancements, and fixes into the CHANGELOG.
-* Update the project version using [semantic versioning](http://semver.org).
-  Specifically:
+> Given a version number MAJOR.MINOR.PATCH, increment the:
+>
+> 1. MAJOR version when you make incompatible API changes,
+> 2. MINOR version when you add functionality in a backwards-compatible
+>    manner, and
+> 3. PATCH version when you make backwards-compatible bug fixes.
 
-  > Given a version number MAJOR.MINOR.PATCH, increment the:
-  >
-  > 1. MAJOR version when you make incompatible API changes,
-  > 2. MINOR version when you add functionality in a backwards-compatible
-  >    manner, and
-  > 3. PATCH version when you make backwards-compatible bug fixes.
-  >
-  > Additional labels for pre-release and build metadata are available as
-  > extensions to the MAJOR.MINOR.PATCH format.
+### Release steps
 
-* Commit and push your changes
-* Add a git tag with the new version of the library
+1. Create a release branch from `next` (e.g. `release/vX.Y.Z`)
+2. Compile new features, enhancements, and fixes into the `CHANGELOG.md`
+3. Make a PR from your release branch into `master`
+4. Once the PR has been approved, merge the release branch into `master`
+5. Create a git tag on `master` with the new version (e.g. `vX.Y.Z`)
+6. Create a new release on GitHub https://github.com/bugsnag/bugsnag-dotnet/releases/new
+  - Use the tag vX.Y.Z as the name of the release
+  - Copy the release notes from `CHANGELOG.md`
+7. Crate a PR from `master` to `next` to keep the branches in sync
+
+### How deployment works
+
+Pushing a git tag triggers an automatic deployment via AppVeyor CI (configured
+in `appveyor.yml`):
+
+* The `Appveyor` Cake task runs, which sets the package version from the git
+  tag and creates NuGet packages (`.nupkg` and `.snupkg` symbol packages)
+* AppVeyor's deploy step detects the tag (`appveyor_repo_tag: true`) and
+  pushes all NuGet and symbol packages to **nuget.org**
+* No manual publish step is needed — tagging the commit is what triggers the
+  release

appveyor.yml

@@ -12,7 +12,7 @@ artifacts:
 deploy:
   - provider: NuGet
     api_key:
-      secure: 0b6P8wGK4Rl0WY7UltuKoMY6xytEPQG3wCr2APXcBM5Kn1ZfPdCnL0Yvvb1UTqxF 
+      secure: ZOltiJQYBDnQdQxzM3eROvsQo5RB4INOv6RqUPtE+j7E2HbdKqI6SNX7h3YxNNkO 
     skip_symbols: false
     symbol_server: https://www.nuget.org/api/v2/symbolpackage
     artifact: /.*(\.|\.s)nupkg/

src/Bugsnag.ConfigurationSection/Configuration.cs

@@ -11,13 +11,13 @@ public class Configuration : System.Configuration.ConfigurationSection, IConfigu
   {
     private static Configuration _configuration = ConfigurationManager.GetSection("bugsnag") as Configuration ?? new Configuration();
 
-    private const string HubKeyPrefix = "00000";
-    private const string HubNotifyUrl = "https://notify.insighthub.smartbear.com";
-    private const string HubSessionsUrl = "https://sessions.insighthub.smartbear.com";
+    private const string SecondaryKeyPrefix = "00000";
+    private const string SecondaryNotifyUrl = "https://notify.bugsnag.smartbear.com";
+    private const string SecondarySessionsUrl = "https://sessions.bugsnag.smartbear.com";
 
-    private static bool IsHubKey(string key) =>
+    private static bool IsSecondaryKey(string key) =>
       !string.IsNullOrEmpty(key) &&
-      key.StartsWith(HubKeyPrefix, StringComparison.OrdinalIgnoreCase);
+      key.StartsWith(SecondaryKeyPrefix, StringComparison.OrdinalIgnoreCase);
 
     public static Configuration Settings
     {
@@ -89,10 +89,10 @@ public Uri Endpoint
     {
       get
       {
-        if (IsHubKey(ApiKey) &&
+        if (IsSecondaryKey(ApiKey) &&
             InternalEndpoint == Bugsnag.Configuration.DefaultEndpoint)
         {
-          return new Uri(HubNotifyUrl);
+          return new Uri(SecondaryNotifyUrl);
         }
         return new Uri(InternalEndpoint);
       }
@@ -406,10 +406,10 @@ public Uri SessionEndpoint
     {
       get
       {
-        if (IsHubKey(ApiKey) &&
+        if (IsSecondaryKey(ApiKey) &&
             InternalSessionEndpoint == Bugsnag.Configuration.DefaultSessionEndpoint)
         {
-          return new Uri(HubSessionsUrl);
+          return new Uri(SecondarySessionsUrl);
         }
         return new Uri(InternalSessionEndpoint);
       }

src/Bugsnag/Configuration.cs

@@ -12,8 +12,8 @@ public class Configuration : IConfiguration
   {
     public const string DefaultEndpoint = "https://notify.bugsnag.com";
     public const string DefaultSessionEndpoint = "https://sessions.bugsnag.com";
-    public const string HubEndpoint = "https://notify.insighthub.smartbear.com";
-    public const string HubSessionEndpoint = "https://sessions.insighthub.smartbear.com";
+    public const string SecondaryEndpoint = "https://notify.bugsnag.smartbear.com";
+    public const string SecondarySessionEndpoint = "https://sessions.bugsnag.smartbear.com";
     private const string HubKeyPrefix = "00000";
 
 
@@ -26,9 +26,9 @@ public Configuration(string apiKey)
     {
       ApiKey = apiKey;
 
-      bool isHubKey = IsHubKey(apiKey);
-      Endpoint = new Uri(isHubKey ? HubEndpoint : DefaultEndpoint);
-      SessionEndpoint = new Uri(isHubKey ? HubSessionEndpoint : DefaultSessionEndpoint);
+      bool isSecondaryKey = IsSecondaryKey(apiKey);
+      Endpoint = new Uri(isSecondaryKey ? SecondaryEndpoint : DefaultEndpoint);
+      SessionEndpoint = new Uri(isSecondaryKey ? SecondarySessionEndpoint : DefaultSessionEndpoint);
 
       AutoNotify = true;
       SessionTrackingInterval = TimeSpan.FromSeconds(60);
@@ -71,8 +71,7 @@ public Configuration(string apiKey)
 
     public int MaximumBreadcrumbs { get; set; }
 
-    private static bool IsHubKey(string key) =>
-  !string.IsNullOrEmpty(key) &&
-  key.StartsWith(HubKeyPrefix, StringComparison.OrdinalIgnoreCase);
+    private static bool IsSecondaryKey(string key) =>
+      !string.IsNullOrEmpty(key) && key.StartsWith(HubKeyPrefix, StringComparison.OrdinalIgnoreCase);
   }
 }

tests/Bugsnag.ConfigurationSection.Tests/EndpointTests.cs

@@ -5,11 +5,11 @@
 namespace Bugsnag.ConfigurationSection.Tests
 {
   /// <summary>
-  /// Verifies that a “Hub”-flavoured API-key (prefix 00000…)
-  /// automatically switches the notify / sessions hosts to InsightHub,
+  /// Verifies that a Secondary-flavoured API-key (prefix 00000…)
+  /// automatically switches the notify / sessions hosts to smartbear.com,
   /// *unless* the user deliberately overrides them in the XML.
   /// </summary>
-  public class HubEndpointTests
+  public class SecondaryEndpointTests
   {
     private static IConfiguration Load(string cfgName)
     {
@@ -21,38 +21,38 @@ private static IConfiguration Load(string cfgName)
     }
 
     /*─────────────────────────────────────────────────────────
-     * 1. Hub key, *default* endpoints  →  InsightHub hosts
+     * 1. Secondary key, *default* endpoints  →  smartbear.com hosts
      *────────────────────────────────────────────────────────*/
     [Fact]
-    public void HubKey_UsesInsightHubHosts_WhenNotOverridden()
+    public void SecondaryKey_UsesSmartbearHosts_WhenNotOverridden()
     {
-      var cfg = Load("HubDefault");   // see HubDefault.config below
+      var cfg = Load("SecondaryDefault");   // see SecondaryDefault.config below
 
       Assert.NotNull(cfg);
       Assert.Equal("00000123456789abcdef0123456789", cfg.ApiKey);
 
-      Assert.Equal(new Uri("https://notify.insighthub.smartbear.com"),   cfg.Endpoint);
-      Assert.Equal(new Uri("https://sessions.insighthub.smartbear.com"), cfg.SessionEndpoint);
+      Assert.Equal(new Uri("https://notify.bugsnag.smartbear.com"), cfg.Endpoint);
+      Assert.Equal(new Uri("https://sessions.bugsnag.smartbear.com"), cfg.SessionEndpoint);
     }
 
     /*─────────────────────────────────────────────────────────
-     * 2. Hub key but custom <endpoint> / <sessionsEndpoint>   →
+     * 2. Secondary key but custom <endpoint> / <sessionsEndpoint>   →
      *    **user preference wins**
      *────────────────────────────────────────────────────────*/
     [Fact]
-    public void HubKey_HonoursCustomEndpoints_WhenPresent()
+    public void SecondaryKey_HonoursCustomEndpoints_WhenPresent()
     {
-      var cfg = Load("HubCustomEndpoint");   // see HubCustomEndpoint.config below
+      var cfg = Load("SecondaryEndpoint");   // see SecondaryEndpoint.config below
 
       Assert.NotNull(cfg);
       Assert.Equal("00000feedfacecafebeefdeadbeef", cfg.ApiKey);
 
-      Assert.Equal(new Uri("https://corp.example.com/notify"),   cfg.Endpoint);
+      Assert.Equal(new Uri("https://corp.example.com/notify"), cfg.Endpoint);
       Assert.Equal(new Uri("https://corp.example.com/sessions"), cfg.SessionEndpoint);
     }
 
     /*─────────────────────────────────────────────────────────
-     * 3. Non-hub key ⇒ still Bugsnag hosts
+     * 3. Non-secondary key ⇒ still Bugsnag hosts
      *────────────────────────────────────────────────────────*/
     [Fact]
     public void ClassicKey_KeepsBugsnagHosts()
@@ -62,7 +62,7 @@ public void ClassicKey_KeepsBugsnagHosts()
       Assert.NotNull(cfg);
       Assert.Equal("abcd1234abcd1234abcd1234abcd1234", cfg.ApiKey);
 
-      Assert.Equal(new Uri(Bugsnag.Configuration.DefaultEndpoint),        cfg.Endpoint);
+      Assert.Equal(new Uri(Bugsnag.Configuration.DefaultEndpoint), cfg.Endpoint);
       Assert.Equal(new Uri(Bugsnag.Configuration.DefaultSessionEndpoint), cfg.SessionEndpoint);
     }
   }

…igurationSection.Tests/HubDefault.config …ionSection.Tests/SecondaryDefault.configtests/Bugsnag.ConfigurationSection.Tests/HubDefault.config renamed to tests/Bugsnag.ConfigurationSection.Tests/SecondaryDefault.config tests/Bugsnag.ConfigurationSection.Tests/HubDefault.config renamed to tests/Bugsnag.ConfigurationSection.Tests/SecondaryDefault.config

@@ -5,6 +5,6 @@
              type="Bugsnag.ConfigurationSection.Configuration, Bugsnag.ConfigurationSection" />
   </configSections>
 
-  <!-- Hub-flavoured key, *no* explicit <endpoint> elements -->
+  <!-- Secondary key, *no* explicit <endpoint> elements -->
   <bugsnag apiKey="00000123456789abcdef0123456789" />
 </configuration>

…onSection.Tests/HubCustomEndpoint.config …onSection.Tests/SecondaryEndpoint.configtests/Bugsnag.ConfigurationSection.Tests/HubCustomEndpoint.config renamed to tests/Bugsnag.ConfigurationSection.Tests/SecondaryEndpoint.config tests/Bugsnag.ConfigurationSection.Tests/HubCustomEndpoint.config renamed to tests/Bugsnag.ConfigurationSection.Tests/SecondaryEndpoint.config

@@ -7,39 +7,39 @@ namespace Bugsnag.Tests
 {
   public class EndpointTests
   {
-    // 5 leading zeroes → Insight Hub
-    private const string HubKey    = "00000aaaaaaaaaaaaaaaaaaaaaaaaaaa";
-    // Any non-hub key → classic Bugsnag
+    // 5 leading zeroes → Secondary
+    private const string SecondaryKey = "00000aaaaaaaaaaaaaaaaaaaaaaaaaaa";
+    // Any non-secondary key → classic
     private const string ClassicKey = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
 
     [Fact]
     public void ClassicKey_Uses_Bugsnag_Hosts()
     {
       var cfg = new CoreConfiguration(ClassicKey);
 
-      Assert.Equal(new Uri(CoreConfiguration.DefaultEndpoint),        cfg.Endpoint);
+      Assert.Equal(new Uri(CoreConfiguration.DefaultEndpoint), cfg.Endpoint);
       Assert.Equal(new Uri(CoreConfiguration.DefaultSessionEndpoint), cfg.SessionEndpoint);
     }
 
     [Fact]
-    public void HubKey_Uses_InsightHub_Hosts()
+    public void SecondaryKey_Uses_Smartbear_Hosts()
     {
-      var cfg = new CoreConfiguration(HubKey);
+      var cfg = new CoreConfiguration(SecondaryKey);
 
-      Assert.Equal(new Uri(CoreConfiguration.HubEndpoint),        cfg.Endpoint);
-      Assert.Equal(new Uri(CoreConfiguration.HubSessionEndpoint), cfg.SessionEndpoint);
+      Assert.Equal(new Uri(CoreConfiguration.SecondaryEndpoint), cfg.Endpoint);
+      Assert.Equal(new Uri(CoreConfiguration.SecondarySessionEndpoint), cfg.SessionEndpoint);
     }
 
     [Fact]
-    public void HubKey_Honours_Custom_Endpoints_When_Provided()
+    public void SecondaryKey_Honours_Custom_Endpoints_When_Provided()
     {
-      var cfg = new CoreConfiguration(HubKey)
+      var cfg = new CoreConfiguration(SecondaryKey)
       {
-        Endpoint        = new Uri("https://notify.example.com"),
+        Endpoint = new Uri("https://notify.example.com"),
         SessionEndpoint = new Uri("https://sessions.example.com")
       };
 
-      Assert.Equal(new Uri("https://notify.example.com"),   cfg.Endpoint);
+      Assert.Equal(new Uri("https://notify.example.com"), cfg.Endpoint);
       Assert.Equal(new Uri("https://sessions.example.com"), cfg.SessionEndpoint);
     }
 
@@ -48,7 +48,7 @@ public void BlankKey_Falls_Back_To_Default_Hosts()
     {
       var cfg = new CoreConfiguration(string.Empty);
 
-      Assert.Equal(new Uri(CoreConfiguration.DefaultEndpoint),        cfg.Endpoint);
+      Assert.Equal(new Uri(CoreConfiguration.DefaultEndpoint), cfg.Endpoint);
       Assert.Equal(new Uri(CoreConfiguration.DefaultSessionEndpoint), cfg.SessionEndpoint);
     }
   }