Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ockam_transport_tcp #1575

Open
jdspdx opened this issue Jul 21, 2021 · 4 comments
Open

Add tests to ockam_transport_tcp #1575

jdspdx opened this issue Jul 21, 2021 · 4 comments

Comments

@jdspdx
Copy link
Contributor

jdspdx commented Jul 21, 2021

Ockam TCP transport provides Ockam Routing support over TCP connections.
The get-started guide has an introductory example of how the TCP transport can be used.

The happy path of TCP Transport works but we should add more unit as well as integration tests.

The functions in this crate are async, so an async testing strategy is needed.


If you would like someone to help / mentor / pair program with you as you work on your first Ockam issue, please leave a comment on this discussion.

@louiidev
Copy link

louiidev commented Aug 5, 2021

@jared-s the introductory example link is broken

@mrinalwadhwa
Copy link
Member

@louisgjohnson thank you for telling us 🙏
We were moving some examples around over the weekend. The correct link to a transport example is https://github.com/ockam-network/ockam/tree/develop/documentation/guides/rust/get-started/04-transport#readme

@nk7608
Copy link
Contributor

nk7608 commented Dec 22, 2021

Glad to have found this issue! I realized the need for more tests while going through the in-depth documentation and I'd be happy to work on this under a mentor.

@etorreborre
Copy link
Member

Hi @nk7608, do you still want to have a look at this issue and need some help to get started?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants