Add validate_dependencies flag to pipeline upload #3357
+86
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
reviewed
Jun 24, 2025
dabarrell
force-pushed
the
db/validate-dependencies
branch
3 times, most recently
from
c4336e8 to
27889b3
Compare
Add test for pipeline upload params
dabarrell
force-pushed
the
db/validate-dependencies
branch
from
6967e15 to
d2bf920
Compare
dabarrell
commented
Jul 3, 2025
| cli.BoolFlag{ | ||
| Name: "validate-dependencies", | ||
| Usage: "When true, validates the dependencies of each step when uploading.", | ||
| EnvVar: "BUILDKITE_PIPELINE_VALIDATE_DEPENDENCIES", |
Contributor
Author
There was a problem hiding this comment.
The env vars in this command don't seem to follow the same pattern, so I just chose one that matched --replace. Alternatively: BUILDKITE_AGENT_PIPELINE_UPLOAD_VALIDATE_DEPENDENCIES ?
Contributor
There was a problem hiding this comment.
BUILDKITE_PIPELINE_VALIDATE_DEPENDENCIES sounds OK to me.
DrJosh9000
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--validate-dependenciesflag to the pipeline upload command, which will fail the upload if any steps depend on keys that don't exist.Context
Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)