Fix a few minor warnings and compiler nits

Author: rtyler

Cargo.toml

@@ -84,6 +84,9 @@ ctrlc = "3.4.6"
 affinity = "0.1.2"
 jemallocator = "0.5.4"
 
+[dev-dependencies]
+serde_yaml = "0.9.34"
+
 # Optimize the heck out of the release build, I have no idea what these flags
 # do
 [profile.release]

src/serve/tls.rs

@@ -79,7 +79,7 @@ fn load_tls_config(state: &ServerState) -> std::io::Result<ServerConfig> {
                 panic!("TLS key could not be properly loaded! This is fatal!");
             }
 
-            if let Some(ca_path) = ca.as_ref() {
+            if let Some(_ca_path) = ca.as_ref() {
                 panic!("Using a custom Certificate Authority is not currently supported!");
             } else {
                 debug!("Loading the certificate and key into the ServerConfig: {cert:?}");

src/sink/kafka.rs

@@ -15,7 +15,7 @@ use serde::Deserialize;
 use tracing::log::*;
 
 use std::collections::HashMap;
-use std::time::{Duration, Instant};
+use std::time::Duration;
 
 use super::{Message, Sink};
 use crate::status::Stats;

src/sink/parquet.rs

@@ -47,9 +47,8 @@ impl Sink for Parquet {
         let (tx, rx) = bounded(1024);
         // [object_store] largely expects environment variables to be all lowercased for
         // consideration as options
-        let opts: HashMap<String, String> = HashMap::from_iter(
-            std::env::vars().map(|(k, v)| (k.to_ascii_lowercase(), v))
-        );
+        let opts: HashMap<String, String> =
+            HashMap::from_iter(std::env::vars().map(|(k, v)| (k.to_ascii_lowercase(), v)));
         let (store, _path) = object_store::parse_url_opts(&config.url, opts)
             .expect("Failed to parse the Parquet sink URL");
         let store = Arc::new(store);
@@ -219,6 +218,21 @@ fn parquet_flush_default() -> usize {
 mod tests {
     use super::*;
 
+    #[test]
+    fn test_deser_config() {
+        let conf = r#"
+---
+url: 's3://bucket'
+        "#;
+        let parquet: Config = serde_yaml::from_str(conf).expect("Failed to deserialize");
+        assert_eq!(parquet.buffer, parquet_buffer_default());
+        assert_eq!(parquet.flush_ms, parquet_flush_default());
+        assert_eq!(
+            parquet.url,
+            Url::parse("s3://bucket").expect("Failed to parse a basic URL")
+        );
+    }
+
     #[test]
     fn test_defaults() {
         assert!(0 < parquet_buffer_default());

src/status.rs

@@ -27,7 +27,7 @@ pub async fn status_server(listen_to: String) -> Result<(), std::io::Error> {
     app.at("/")
         .get(|_| async move { Ok("hotdog status server") });
 
-    app.at("/stats").get(|req: Request<()>| async move {
+    app.at("/stats").get(|_req: Request<()>| async move {
         let health: HashMap<String, String> = HashMap::default();
 
         let mut res = Response::new(StatusCode::Ok);